10
45
Fork
You've already forked doipjs
28

Switch from yarn to npm #69

Closed
yarmo wants to merge 1 commit from yarn-to-npm into dev
pull from: yarn-to-npm
merge into: keyoxide:dev
keyoxide:main
keyoxide:dev
keyoxide:fix-irc-fetcher
keyoxide:new-claim-eveonline-143
keyoxide:prepare-new-release
keyoxide:fix-jsdoc-types
keyoxide:support-openpgp-aspe-claims
keyoxide:support-html-alias
keyoxide:improve-activitypub-support
keyoxide:v1-restructure
keyoxide:into-es-module
keyoxide:support-aspe
keyoxide:fix-js-lsp-issues
keyoxide:improve-linting
keyoxide:add-markers
keyoxide:support-opencollective-claim
keyoxide:support-entity-decoding
keyoxide:use-rome-tools
keyoxide:support-cloudflare-buster
keyoxide:support-fediverse-posts
keyoxide:matrix-room-verification
Owner
Copy link

This PR switches the library from using yarn as package manager to npm. It was recently pointed out that yarn may not be such a good solution anymore.

Tests run fine after a "naive" switch. The library also builds without a problem.

An open question is whether this warrants a breaking change.

This PR switches the library from using yarn as package manager to npm. It was recently pointed out that yarn may not be such a good solution anymore. Tests run fine after a "naive" switch. The library also builds without a problem. An open question is whether this warrants a breaking change.
chore: switch from yarn to npm
All checks were successful
ci/woodpecker/push/test Pipeline was successful
ci/woodpecker/pr/test Pipeline was successful
ci/woodpecker/pull_request_closed/test Pipeline was successful
440062796d
Ryuno-Ki left a comment
Copy link

This is fine.

This is fine.

Since I brought it up on Matrix:

Breaking Change insofar that at the very least I would highlight it in the Changelog.
I only noticed because Debian Linux on my system updated Yarn to v4 and the next yarnpkg updated the yarn.lock file.
In Matrix the argument was made, that the development of Yarn Berry is uncertain and some Plug-and-Play isn't stable (I don't remember the details).

Alternative to moving to npm (by Microsoft) would be pnpm. The largest community is still around npm.

Since I brought it up on Matrix: Breaking Change insofar that at the very least I would highlight it in the Changelog. I only noticed because Debian Linux on my system updated Yarn to v4 and the next `yarnpkg` updated the `yarn.lock` file. In Matrix the argument was made, that the development of Yarn Berry is uncertain and some Plug-and-Play isn't stable (I don't remember the details). Alternative to moving to npm (by Microsoft) would be [pnpm](https://pnpm.io/). The largest community is still around `npm`.
Author
Owner
Copy link

I don't have experience with pnpm. I could try it out but I have little foundation to make an informed decision about npm vs pnpm.

I don't have experience with pnpm. I could try it out but I have little foundation to make an informed decision about npm vs pnpm.

My comment was meant as a record to future you.

My comment was meant as a record to future you.

Merge Conflicts.

Merge Conflicts.
Author
Owner
Copy link

That's alright. It's a simple "delete file and run npm" operation, I will not merge a PR but rather just do it on dev (or make a new PR and immediately merge but that's just the same thing IMO)

That's alright. It's a simple "delete file and run npm" operation, I will not merge a PR but rather just do it on dev (or make a new PR and immediately merge but that's just the same thing IMO)
Author
Owner
Copy link

I created a new PR that will perform the switch to NPM: #104.

I created a new PR that will perform the switch to NPM: https://codeberg.org/keyoxide/doipjs/pulls/104.
yarmo closed this pull request 2024年06月02日 16:42:11 +02:00
All checks were successful
ci/woodpecker/push/test Pipeline was successful
ci/woodpecker/pr/test Pipeline was successful
ci/woodpecker/pull_request_closed/test Pipeline was successful

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
bug
Something is not working

Archived

enhancement
New feature

Archived

Contribution welcome
Get started contributing here
Good first issue
Good if you are new to the project or to open source contributions
Impact
External
 Affects the people using the project
Impact
Internal
 Affects on the people working on the project
Priority
Critical
 Work on right now
Priority
High
 Work on at earliest convenience
Priority
Low
 Work on in spare time
Priority
Medium
 Work on regularly
Review
Duplicate
 Already exists
Review
Off Topic
 Does not fall within the scope of the repo/project
Status
Backlog
 Is not being worked on yet
Status
Blocked
 Is waiting on something or someone
Status
Completed
 Is done
Status
In Progress
 Is being worked on
Status
Investigating
 Is waiting on research or questions
Status
Needs Decision
 Is waiting on a decision by the devs/contributors
Status
Needs Info
 Is waiting on additional information before it can be solved
Status
Needs Triage
 Is new issue that needs reviewing
Status
Testing
 Is being checked and verified
Status
Waiting For Review
 Is waiting on reviewers to approve
Status
Won't Fix
 Won't be fixed
Type
Bug
 Related to something not working as intended
Type
CI
 Related to continuous integration
Type
Documentation
 Related to documentation
Type
Enhancement
 Related to a new feature or an improved one
Type
New Claim
 Related to a new identity claim/proof
Type
Security
 Related to security
Type
Tests
 Related to code tests
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
keyoxide/doipjs!69
Reference in a new issue
keyoxide/doipjs
No description provided.
Delete branch "yarn-to-npm"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?