10
45
Fork
You've already forked doipjs
28

Support OpenPGP/ASPE claims #66

Merged
yarmo merged 2 commits from support-openpgp-aspe-claims into dev 2024年01月23日 18:53:20 +01:00
Owner
Copy link

This PR adds support for identity claims to target other identity profiles, be they OpenPGP profiles or ASP profiles.

This PR adds support for identity claims to target other identity profiles, be they OpenPGP profiles or ASP profiles.
feat: support ASPE claims
All checks were successful
ci/woodpecker/push/test Pipeline was successful
ci/woodpecker/pr/test Pipeline was successful
ci/woodpecker/pull_request_closed/test Pipeline was successful
4a77591c57
@ -0,0 +71,4 @@
})
return Promise.race([fetchPromise, timeoutPromise]).then((result) => {
clearTimeout(timeoutHandle)
Owner
Copy link

I would move this into .finally() because of the timeoutPromise wins, the Promise.race will be rejected and therefore not execute the then callback.

I would move this into [`.finally()`](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Promise/finally) because of the `timeoutPromise` wins, the `Promise.race` will be rejected and therefore not execute the `then` callback.
Author
Owner
Copy link

That makes a lot of sense! All the fetchers work roughly the same, so they all have this flaw, will fix that right away

That makes a lot of sense! All the fetchers work roughly the same, so they all have this flaw, will fix that right away
Author
Owner
Copy link

Fixed with a9c1ffabfe

Fixed with https://codeberg.org/keyoxide/doipjs/commit/a9c1ffabfe3925623d738911ef5bbf2232acb79d
@ -0,0 +39,4 @@
})
const fetchPromise = new Promise((resolve, reject) => {
const reURI = /^aspe:([a-zA-Z0-9.\-_]*):([a-zA-Z0-9]*)/
Owner
Copy link

This regular expression is created every time. A micro-optimisation could be to move it out of the function into module scope.

This regular expression is created every time. A micro-optimisation could be to move it out of the function into module scope.
Author
Owner
Copy link

Smart! Will fix right away

Smart! Will fix right away
Author
Owner
Copy link

Fixed with 7639962521

Fixed with https://codeberg.org/keyoxide/doipjs/commit/7639962521e71d8f3741c13c35caf8ae3c51e893
Sign in to join this conversation.
No reviewers
Labels
Clear labels
bug
Something is not working

Archived

enhancement
New feature

Archived

Contribution welcome
Get started contributing here
Good first issue
Good if you are new to the project or to open source contributions
Impact
External
 Affects the people using the project
Impact
Internal
 Affects on the people working on the project
Priority
Critical
 Work on right now
Priority
High
 Work on at earliest convenience
Priority
Low
 Work on in spare time
Priority
Medium
 Work on regularly
Review
Duplicate
 Already exists
Review
Off Topic
 Does not fall within the scope of the repo/project
Status
Backlog
 Is not being worked on yet
Status
Blocked
 Is waiting on something or someone
Status
Completed
 Is done
Status
In Progress
 Is being worked on
Status
Investigating
 Is waiting on research or questions
Status
Needs Decision
 Is waiting on a decision by the devs/contributors
Status
Needs Info
 Is waiting on additional information before it can be solved
Status
Needs Triage
 Is new issue that needs reviewing
Status
Testing
 Is being checked and verified
Status
Waiting For Review
 Is waiting on reviewers to approve
Status
Won't Fix
 Won't be fixed
Type
Bug
 Related to something not working as intended
Type
CI
 Related to continuous integration
Type
Documentation
 Related to documentation
Type
Enhancement
 Related to a new feature or an improved one
Type
New Claim
 Related to a new identity claim/proof
Type
Security
 Related to security
Type
Tests
 Related to code tests
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
keyoxide/doipjs!66
Reference in a new issue
keyoxide/doipjs
No description provided.
Delete branch "support-openpgp-aspe-claims"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?