10
45
Fork
You've already forked doipjs
28

Introduce ClaimError object for tracking errors #58

Open
aspensmonster wants to merge 8 commits from aspensmonster/doipjs:introduce-extended-error-messages into dev
pull from: aspensmonster/doipjs:introduce-extended-error-messages
merge into: keyoxide:dev
keyoxide:main
keyoxide:dev
keyoxide:fix-irc-fetcher
keyoxide:new-claim-eveonline-143
keyoxide:prepare-new-release
keyoxide:fix-jsdoc-types
keyoxide:yarn-to-npm
keyoxide:support-openpgp-aspe-claims
keyoxide:support-html-alias
keyoxide:improve-activitypub-support
keyoxide:v1-restructure
keyoxide:into-es-module
keyoxide:support-aspe
keyoxide:fix-js-lsp-issues
keyoxide:improve-linting
keyoxide:add-markers
keyoxide:support-opencollective-claim
keyoxide:support-entity-decoding
keyoxide:use-rome-tools
keyoxide:support-cloudflare-buster
keyoxide:support-fediverse-posts
keyoxide:matrix-room-verification
Contributor
Copy link

This piggybacks off of #57, so only the last three commits are actually what's changed here. Given that we're looking to use i18next, I adjusted ClaimError's args property to be an object, as that can be passed into i18next.t() for interpolating the values during localization.

This piggybacks off of #57, so only the last three commits are actually what's changed here. Given that we're looking to use `i18next`, I adjusted `ClaimError`'s `args` property to be an `object`, as that can be passed into `i18next.t()` for interpolating the values during localization.
Author
Contributor
Copy link

The only test that failed is an integration test that tests for a DNS record that is known to fail: dns:big.tech.corporation?type=TXT. I'm not sure if that's a problem of the woodpecker environment not being allowed to make DNS requests or what, since the test timed out after 2000ms. Locally, it typically completes in under 100ms. I can remove the test if needed. Just wanted to have something on the verify step that showed ClaimErrors were getting made.

The only test that failed is an integration test that tests for a DNS record that is known to fail: `dns:big.tech.corporation?type=TXT`. I'm not sure if that's a problem of the woodpecker environment not being allowed to make DNS requests or what, since the test timed out after 2000ms. Locally, it typically completes in under 100ms. I can remove the test if needed. Just wanted to have something on the `verify` step that showed `ClaimError`s were getting made.
aspensmonster force-pushed introduce-extended-error-messages from b0642170cb
Some checks failed
ci/woodpecker/pr/test Pipeline failed
ci/woodpecker/pr/publish-npm unknown status
to 4eff73c4a8
Some checks failed
ci/woodpecker/pr/test Pipeline failed
ci/woodpecker/pr/publish-npm unknown status
2023年09月20日 23:10:22 +02:00 Compare
Merge branch 'dev' into introduce-extended-error-messages
Some checks failed
ci/woodpecker/pr/test Pipeline failed
784a0e84ee 
Sync with dev branch
Remove failing test for now
All checks were successful
ci/woodpecker/pr/test Pipeline was successful
a7a5c2d85b
All checks were successful
ci/woodpecker/pr/test Pipeline was successful
This pull request has changes conflicting with the target branch.
  • src/claim.js
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u introduce-extended-error-messages:aspensmonster-introduce-extended-error-messages
git switch aspensmonster-introduce-extended-error-messages
Sign in to join this conversation.
No reviewers
Labels
Clear labels
bug
Something is not working

Archived

enhancement
New feature

Archived

Contribution welcome
Get started contributing here
Good first issue
Good if you are new to the project or to open source contributions
Impact
External
 Affects the people using the project
Impact
Internal
 Affects on the people working on the project
Priority
Critical
 Work on right now
Priority
High
 Work on at earliest convenience
Priority
Low
 Work on in spare time
Priority
Medium
 Work on regularly
Review
Duplicate
 Already exists
Review
Off Topic
 Does not fall within the scope of the repo/project
Status
Backlog
 Is not being worked on yet
Status
Blocked
 Is waiting on something or someone
Status
Completed
 Is done
Status
In Progress
 Is being worked on
Status
Investigating
 Is waiting on research or questions
Status
Needs Decision
 Is waiting on a decision by the devs/contributors
Status
Needs Info
 Is waiting on additional information before it can be solved
Status
Needs Triage
 Is new issue that needs reviewing
Status
Testing
 Is being checked and verified
Status
Waiting For Review
 Is waiting on reviewers to approve
Status
Won't Fix
 Won't be fixed
Type
Bug
 Related to something not working as intended
Type
CI
 Related to continuous integration
Type
Documentation
 Related to documentation
Type
Enhancement
 Related to a new feature or an improved one
Type
New Claim
 Related to a new identity claim/proof
Type
Security
 Related to security
Type
Tests
 Related to code tests
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
keyoxide/doipjs!58
Reference in a new issue
keyoxide/doipjs
No description provided.
Delete branch "aspensmonster/doipjs:introduce-extended-error-messages"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?