Use more generic Account entity rather than Collective entity #55

aspensmonster commented 2023年08月16日 23:43:55 +02:00

As per

https://graphql-docs-v2.opencollective.com/types/Account

Account interface shared by all kind of accounts (Bot, Collective,
Event, User, Organization)

I ran into trouble originally in

keyoxide/keyoxide-web#166

trying to figure out why a keypair parsing was failing (invalid URI on one of the signatures). Then, after addressing that via #54, I kept digging to see why the OpenCollective entry was failing, as the entity existed on OpenCollective:

https://opencollective.com/arubes

and had the following in its long description:

openpgp4fpr:68F640A166E2AD7BD22647B75E1A61D9DC1E1C73

So it should have worked. Looking at the response, arubes in OpenCollective is not a Collective type, but an Individual type. Querying the Account type works not only for Collective and the aforementioned other types (Bot, Event, User, Organization), but appears also to return Individual types too:

$ cat oc4.json 
{
	"query": "query { account(slug: \"arubes\") { longDescription } }"
}
$ curl -H 'Content-Type: application/json' -X POST https://api.opencollective.com/graphql/v2 -d@oc4.json
{"data":{"account":{"longDescription":"<div> openpgp4fpr:68F640A166E2AD7BD22647B75E1A61D9DC1E1C73 </div>"}}}
$

Querying on this entity should, in theory, be more general and handle more types of OpenCollective users.

As per https://graphql-docs-v2.opencollective.com/types/Account >Account interface shared by all kind of accounts (Bot, Collective, Event, User, Organization) I ran into trouble originally in https://codeberg.org/keyoxide/keyoxide-web/issues/166 trying to figure out why a keypair parsing was failing (invalid URI on one of the signatures). Then, after addressing that via #54, I kept digging to see why the OpenCollective entry was failing, as the entity existed on OpenCollective: https://opencollective.com/arubes and had the following in its long description: `openpgp4fpr:68F640A166E2AD7BD22647B75E1A61D9DC1E1C73 ` So it should have worked. Looking at the response, `arubes` in OpenCollective is not a `Collective` type, but an `Individual` type. Querying the `Account` type works not only for `Collective` and the aforementioned other types (`Bot`, `Event`, `User`, `Organization`), but appears also to return `Individual` types too: ``` $ cat oc4.json { "query": "query { account(slug: \"arubes\") { longDescription } }" } $ curl -H 'Content-Type: application/json' -X POST https://api.opencollective.com/graphql/v2 -d@oc4.json {"data":{"account":{"longDescription":"<div> openpgp4fpr:68F640A166E2AD7BD22647B75E1A61D9DC1E1C73 </div>"}}} $ ``` Querying on this entity should, in theory, be more general and handle more types of OpenCollective users.

yarmo commented 2023年09月14日 17:33:30 +02:00

Good catch! Thanks for making a PR for this

Good catch! Thanks for making a PR for this