keyoxide/doipjs

Fork 28

Code Issues 56 Pull requests 24 Projects Releases 89 Activity

Add support for polkadot address claim #33

Open

sorpaas wants to merge 2 commits from sorpaas/doipjs:sp-polkadot into main

pull from: sorpaas/doipjs:sp-polkadot

merge into: keyoxide:main

keyoxide:main

keyoxide:dev

keyoxide:fix-irc-fetcher

keyoxide:new-claim-eveonline-143

keyoxide:prepare-new-release

keyoxide:fix-jsdoc-types

keyoxide:yarn-to-npm

keyoxide:support-openpgp-aspe-claims

keyoxide:support-html-alias

keyoxide:improve-activitypub-support

keyoxide:v1-restructure

keyoxide:into-es-module

keyoxide:support-aspe

keyoxide:fix-js-lsp-issues

keyoxide:improve-linting

keyoxide:add-markers

keyoxide:support-opencollective-claim

keyoxide:support-entity-decoding

keyoxide:use-rome-tools

keyoxide:support-cloudflare-buster

keyoxide:support-fediverse-posts

keyoxide:matrix-room-verification

Conversation 1 Commits 2 Files changed 5 +112 -29

sorpaas commented

2023年01月08日 12:58:43 +01:00

First-time contributor

Copy link

This PR adds support to allow verifying ownership of Polkadot addresses. The claim is written as text, and the address owner is expected to put it as a system.remark on-chain message (called "extrinsic" in Polkadot). We can then use any blockchain explorer to retrieve that and verify ownership.

Some extensions to the claim definitions have to be written. Support for POST HTTP method was added, as well as a new claim relation EXACTEQUAL. The latter is needed to verify that the sender of the on-chain message is the same as the address to be verified. I think this is actually needed by Github claims as well -- the API currently only checks for https://api.github.com/gists/<id> but not the actual profile name.

In principle, the same method can work for Ethereum as it's similar. For Bitcoin, due to UTXO and the strong focus to never reuse addresses, it's probably not really useful to verify address ownership.

This PR adds support to allow verifying ownership of Polkadot addresses. The claim is written as text, and the address owner is expected to put it as a `system.remark` on-chain message (called "extrinsic" in Polkadot). We can then use any blockchain explorer to retrieve that and verify ownership. Some extensions to the claim definitions have to be written. Support for POST HTTP method was added, as well as a new claim relation `EXACTEQUAL`. The latter is needed to verify that the sender of the on-chain message is the same as the address to be verified. I think this is actually needed by Github claims as well -- the API currently only checks for `https://api.github.com/gists/<id>` but not the actual profile name. In principle, the same method can work for Ethereum as it's similar. For Bitcoin, due to UTXO and the strong focus to never reuse addresses, it's probably not really useful to verify address ownership.

sorpaas added 1 commit

2023年01月08日 12:58:47 +01:00

Add support for polkadot address claim

All checks were successful

continuous-integration/drone/pr Build is passing

Details

89fa0ee017

sorpaas added 1 commit

2023年01月08日 13:03:11 +01:00

Should use claim.relation

All checks were successful

continuous-integration/drone/pr Build is passing

Details

aa049770c3

yarmo commented

2023年01月22日 16:06:12 +01:00

Owner

Copy link

Thanks for the PR, and sorry for my late response.

Some interesting changes in this PR, I like the GET/POST support. It is also thanks to your EXACTEQUALS that I noticed how far I strayed with the EQUALS method. But even if that behavior is changed in the future, an EXACTEQUALS will be handy to have, so thanks.

Now, I am not overly familiar with polkadot. Would it be possible for you to give me an example of a proof?

Thanks for the PR, and sorry for my late response. Some interesting changes in this PR, I like the GET/POST support. It is also thanks to your `EXACTEQUALS` that I noticed how far I strayed with the `EQUALS` method. But even if that behavior is changed in the future, an `EXACTEQUALS` will be handy to have, so thanks. Now, I am not overly familiar with polkadot. Would it be possible for you to give me an example of a proof?

All checks were successful

continuous-integration/drone/pr Build is passing

Details

This pull request has changes conflicting with the target branch.