@chimbosonic wrote in https://codeberg.org/keyoxide/doipjs/pulls/151#issuecomment-4989294: > @quokka I’m not sure why your change includes changes to the mediawiki provider. If it’s needed can you unpick it and put it in a separate PR please. Fixed 👍

chimbosonic commented

2025年06月04日 16:00:46 +02:00

Member

Copy link

Looks good to me tho I'm not a fan of try catch syntax. @Ryuno-Ki does it look ok?

😕 1

quokka added 1 commit

2025年06月06日 22:02:52 +02:00

Changed NIP-05 logic to prevent impersonation, e.g.jo_@hn.com impersonating john.com d6f0fd312c

quokka added 1 commit

2025年06月07日 11:24:56 +02:00

Only remove _@ from NIP-05 when displayed in postprocess function bdc4e85364

quokka added 1 commit

2025年06月07日 11:44:33 +02:00

Fix documentation dd7a4a67a0

Ryuno-Ki requested changes

2025年06月10日 12:32:04 +02:00

Dismissed

Ryuno-Ki left a comment

Copy link

Looks largely okay. I'm missing some comments mainly.

src/fetcher/nostr.js Outdated

@ -0,0 +36,4 @@

* @function

* @param {object} data - Data used in the request

* @param {string} data.eventId - The ID of the event containing the proof

* @param {string[]} data.relays - Relays to fall back on in case NIP-19 does not contain any

Ryuno-Ki commented

2025年06月10日 12:21:01 +02:00

Owner

Copy link

Nitpick: I prefer Array<string> over string[] (see the return type in line 42).
This isn't blocking the PR.

Nitpick: I prefer `Array<string>` over `string[]` (see the return type in line 42). This isn't blocking the PR.

quokka marked this conversation as resolved

src/fetcher/nostr.js

@ -0,0 +37,4 @@

* @param {object} data - Data used in the request

* @param {string} data.eventId - The ID of the event containing the proof

* @param {string[]} data.relays - Relays to fall back on in case NIP-19 does not contain any

* @param {number} [data.fetcherTimeout] - Optional timeout for the fetcher

Ryuno-Ki commented

2025年06月10日 12:21:44 +02:00

Owner

Copy link

Would be great to have the unit. But we don't mention it elsewhere so this isn't blocking here.

quokka marked this conversation as resolved

src/fetcher/nostr.js Outdated

@ -0,0 +79,4 @@

const result = { event }

result.npub = nip19.npubEncode(event.pubkey)

return pool.get(relays, { kinds: [0], authors: [event.pubkey] })

Ryuno-Ki commented

2025年06月10日 12:23:44 +02:00

Owner

Copy link

The 0 has a special meaning in Nostr land. Can you declare a const and refer to it here?

The `0` has a special meaning in Nostr land. Can you declare a const and refer to it here?

quokka commented

2025年06月10日 15:32:56 +02:00

Author

Contributor

Copy link

As in

const profileKind = 0
// ...
return pool.get(relays, { kinds: [profileKind], authors: [event.pubkey] })

Maybe I'm misunderstanding what you mean, but I don't see why it should be a seperate constant. Events of kind 0 just means it's profile metadata, e.g. display name and NIP-05 handle.

As in ```js const profileKind = 0 // ... return pool.get(relays, { kinds: [profileKind], authors: [event.pubkey] }) ``` ? Maybe I'm misunderstanding what you mean, but I don't see why it should be a seperate constant. Events of kind `0` just means it's profile metadata, e.g. display name and NIP-05 handle.

👍 1

Ryuno-Ki commented

2025年06月10日 18:48:30 +02:00

Owner

Copy link

Exactly that.

quokka marked this conversation as resolved

src/fetcher/nostr.js Outdated

@ -0,0 +86,4 @@

}

let profileContent

try {

Ryuno-Ki commented

2025年06月10日 12:24:29 +02:00

Owner

Copy link

Hm, nested try/catch constructs. If it fails, the outer catch ought to handle it.

quokka marked this conversation as resolved

src/fetcher/nostr.js Outdated

@ -0,0 +91,4 @@

profile.content = profileContent

} catch (_) { }

 // if there’s a nip05 field, look it up

Ryuno-Ki commented

2025年06月10日 12:28:53 +02:00

Owner

Copy link

s/there’s/there's/

(you used the „wrong" typographic character here - you used single quotation mark U+2019 whereas apostrophe U+0027 would have been correct).

s/there’s/there's/ (you used the „wrong" typographic character here - you used single quotation mark U+2019 whereas apostrophe U+0027 would have been correct).

quokka marked this conversation as resolved

src/fetcher/nostr.js Outdated

@ -0,0 +92,4 @@

} catch (_) { }

 // if there’s a nip05 field, look it up

if (profileContent && profileContent.nip05) {

Ryuno-Ki commented

2025年06月10日 12:29:23 +02:00

Owner

Copy link

Can be shortened to if (profileContent?.nip05) { /*...*/ }.

Can be shortened to `if (profileContent?.nip05) { /*...*/ }`.

quokka marked this conversation as resolved

src/serviceProviders/nostr.js Outdated

@ -0,0 +33,4 @@

*/

export function processURI (uri) {

const match = uri.match(reURI)

const relays = [

Ryuno-Ki commented

2025年06月10日 12:30:32 +02:00

Owner

Copy link

Please add a comment pointing to the source from which you extracted these relays.

quokka marked this conversation as resolved

src/serviceProviders/nostr.js

@ -0,0 +65,4 @@

},

proof: {

request: {

uri: `https://njump.me/${match[1]}`,

Ryuno-Ki commented

2025年06月10日 12:31:25 +02:00

Owner

Copy link

Might be worth to have a comment here that explains that this is a bridge between Nostr-land and HTTP world. Also: where / how could we find an alternative if this service shuts down?

quokka marked this conversation as resolved

quokka added 1 commit

2025年06月10日 17:05:58 +02:00

Implement André's suggestions 9e5320b7f6

Ryuno-Ki approved these changes

2025年06月10日 18:51:13 +02:00

Dismissed

Ryuno-Ki left a comment

Copy link

You're a rebase / merge away from integration here.

quokka added 1 commit

2025年06月10日 19:46:01 +02:00