added an optional verify parameter for requests #34

Closed

smyja wants to merge 1 commit from main into main

pull from: main

merge into: jpt:main

jpt:gh-pages

jpt:november-updates

jpt:log-config

jpt:pagination-restore

Conversation 1 Commits 1 Files changed 1 +6 -3

smyja commented

2023年03月26日 13:32:14 +02:00

(Migrated from github.com)

Copy link

This pull requests allows for people to disable ssl check due to some pages not having it. This fixes #33

jamesturk commented

2023年03月26日 18:47:09 +02:00

(Migrated from github.com)

Copy link

Hi and thanks for the interest!

Right now, I would encourage you to call requests.get before the call to the scraper and pass in the resulting HTML. I want to avoid the scrape method growing every possible parameter to requests.get() (and requests.post, etc.) Think of this library as primarily a way to parse the HTML, not retrieve it.

Hi and thanks for the interest! Right now, I would encourage you to call requests.get before the call to the scraper and pass in the resulting HTML. I want to avoid the scrape method growing every possible parameter to requests.get() (and requests.post, etc.) Think of this library as primarily a way to parse the HTML, not retrieve it.

Pull request closed

Please reopen this pull request to perform a merge.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

jpt/scrapeghost!34

No description provided.

Delete branch "main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?