1
0
Fork
You've already forked monero
0

net/i2p: support human-readable hostnames #3

Open
jpk68 wants to merge 1 commit from i2p-addresses into master
pull from: i2p-addresses
merge into: jpk68:master
jpk68:master
jpk68:i2p-sam
jpk68:asio-headers
jpk68:systemd
jpk68:openrc-service
jpk68:threadpool-thread-local
jpk68:wallet-dir
jpk68:ifdef-glibc
jpk68:remove-dead-onion-node
jpk68:remove-whitespace
jpk68:onion-old
jpk68:add-key
jpk68:russian-name
jpk68:missing-fish
jpk68:sccache
jpk68:rust-cmake
jpk68:util-fix
jpk68:remove-win32
jpk68:broken-copyright
jpk68:dns-utils
jpk68:manpages
jpk68:contrib-license
jpk68:contrib-docs
jpk68:fcmp-pp-rust-build
jpk68:sccache-build
jpk68:remove-msvc
jpk68:fcmp++-stage
jpk68:onion-karma
jpk68:wallet2-i2p-error
jpk68:human-readable-timespan
jpk68:fix-log
jpk68:dead-prs
jpk68:markdown-link
jpk68:monerod-conf
jpk68:device-typos
Owner
Copy link

Adds support for standard, human-readable I2P hostnames in addition to Base32 ones. It effectively fixes this TODO, and is intended to be built off of by a later SAM integration PR. Some improvements have also been made to general hostname validation logic, in terms of conforming to naming rules and the like.

An example: foo.i2p may be used instead of xmrdoc6k4licya7zsnba5s7vugzo72blcpukkvqno75o4ruhaqla.b32.i2p.

To my knowledge, the changes made here do not render existing I2P documentation for Monero (i.e. this) outdated; I do plan on updating the docs on a later date, however modifications can instead be made sooner if necessary.

Adds support for standard, human-readable I2P hostnames in addition to Base32 ones. It effectively fixes [this TODO](https://github.com/monero-project/monero/blob/master/src/net/i2p_address.cpp#L47C9-L47C46), and is intended to be built off of by a later [SAM](https://i2p.net/en/docs/api/samv3/) integration PR. Some improvements have also been made to general hostname validation logic, in terms of conforming to [naming rules](https://i2p.net/en/docs/overview/naming/#naming-rules) and the like. An example: `foo.i2p` may be used instead of `xmrdoc6k4licya7zsnba5s7vugzo72blcpukkvqno75o4ruhaqla.b32.i2p`. To my knowledge, the changes made here do not render existing I2P documentation for Monero (i.e. [this](https://github.com/monero-project/monero/blob/master/docs/ANONYMITY_NETWORKS.md)) outdated; I do plan on updating the docs on a later date, however modifications can instead be made sooner if necessary.
jpk68 changed title from (削除) i2p: add support for human-readable hostnames (削除ここまで) to net/i2p: support human-readable hostnames 2026年04月24日 20:36:10 +02:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin i2p-addresses:i2p-addresses
git switch i2p-addresses

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff i2p-addresses
git switch i2p-addresses
git rebase master
git switch master
git merge --ff-only i2p-addresses
git switch i2p-addresses
git rebase master
git switch master
git merge --no-ff i2p-addresses
git switch master
git merge --squash i2p-addresses
git switch master
git merge --ff-only i2p-addresses
git switch master
git merge i2p-addresses
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jpk68/monero!3
Reference in a new issue
jpk68/monero
No description provided.
Delete branch "i2p-addresses"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?