• Joined on 2026年02月26日
jandrews271 commented on pull request river/tinyrwm#2 2026年03月11日 17:51:37 +01:00
Rust implementation

I've pushed fixes that I think should be good for most of the issues. The focus issues still need attention, but I may not get to that until the weekend. Quick summary of where I'm leaving off:

jandrews271 commented on pull request river/tinyrwm#2 2026年03月11日 17:22:58 +01:00
Rust implementation

So, this is definitely one source of differences from the C implementation.

jandrews271 commented on pull request river/tinyrwm#2 2026年03月11日 16:43:55 +01:00
Rust implementation

I think this probably isn't an issue. seat.interacted.take() resets the value to None (and is the idiomatic way to clear an Option and use the contents).

jandrews271 pushed to rust at jandrews271/tinyrwm 2026年03月11日 16:37:48 +01:00
40244e9edc Fix FocusNext action
jandrews271 pushed to rust at jandrews271/tinyrwm 2026年03月11日 15:38:08 +01:00
0b67d16f94 Refactor to move bindings to seat
jandrews271 commented on pull request river/tinyrwm#2 2026年03月11日 15:30:51 +01:00
Rust implementation

This should be fixed with the bindings -> seat refactor. I originally had this in place to deal with some borrow checker complaints, but the new data model fixed that entirely.

jandrews271 commented on pull request river/tinyrwm#2 2026年03月11日 15:27:14 +01:00
Rust implementation

Passing the ObjectId is actually perfect. This is a huge improvement, and I think the pattern of passing around ObjectIds as user data is probably the right default for Rust since it bypasses...

jandrews271 pushed to rust at jandrews271/tinyrwm 2026年03月11日 14:58:01 +01:00
3a05fd8730 Fix window removal seatop end bug
jandrews271 commented on pull request river/tinyrwm#2 2026年03月11日 14:36:26 +01:00
Rust implementation

Whoops! Should be fixed now.

jandrews271 commented on pull request river/tinyrwm#2 2026年03月11日 14:23:20 +01:00
Rust implementation

Updated! I didn't follow the Go implementation exactly. For Rust at least, keeping the proxy in the enum with the rest of the operation-specific state is cleaner, and it didn't seem worth having a...

jandrews271 pushed to rust at jandrews271/tinyrwm 2026年03月11日 14:16:57 +01:00
7c120f04ad Refactor seat ops pushing data to the enum
a6d718c159 Replace a few unwrap calls with expect
749b119d0d Drop find_or_log! in favor of simple expect
d5b7ffa3ad Drop tiny helper functions
824cdedbef Add README
Compare 16 commits »
jandrews271 pushed to rust at jandrews271/tinyrwm 2026年03月11日 14:16:32 +01:00
3c84b20805 Refactor seat ops pushing data to the enum
2ec013fff4 Replace a few unwrap calls with expect
1dc9943fa4 Drop find_or_log! in favor of simple expect
5c07384f45 Drop tiny helper functions
4f69033b39 Add README
Compare 8 commits »
jandrews271 commented on pull request river/tinyrwm#2 2026年03月11日 13:00:26 +01:00
Rust implementation

Yup! Done.

jandrews271 pushed to rust at jandrews271/tinyrwm 2026年03月11日 12:58:25 +01:00
3da9ae5789 Replace a few unwrap calls with expect
675a870d46 Drop find_or_log! in favor of simple expect
766a3a6dad Drop tiny helper functions
dabd273ac4 Add README
53bbbe1aaa Implement tinyrwm
Compare 15 commits »
jandrews271 pushed to rust at jandrews271/tinyrwm 2026年03月11日 12:57:40 +01:00
2ec013fff4 Replace a few unwrap calls with expect
1dc9943fa4 Drop find_or_log! in favor of simple expect
5c07384f45 Drop tiny helper functions
Compare 3 commits »
jandrews271 commented on pull request river/tinyrwm#2 2026年03月11日 12:41:17 +01:00
Rust implementation

Done!

jandrews271 commented on pull request river/tinyrwm#2 2026年03月11日 12:33:56 +01:00
Rust implementation

It's a little awkward, but we could do it.

jandrews271 commented on pull request river/tinyrwm#2 2026年03月11日 12:07:03 +01:00
Rust implementation

I don't think it should ever happen without a bug. I think at the time I was thinking that logging an error message was better than panicking if it did happen, but I can see the argument either way.

jandrews271 created pull request river/tinyrwm#2 2026年03月09日 21:21:54 +01:00
Rust implementation
jandrews271 created branch rust in jandrews271/tinyrwm 2026年03月09日 21:13:22 +01:00