Add support to rewrite Reddit links to Teddit #4

ltguillaume commented 2020年11月28日 21:23:19 +01:00

No description provided.

izzy commented 2020年11月28日 21:49:25 +01:00

Thanks! Tried it and it works (first wondered why it failed, so a note: one explicitly needs to set a teddit instance after updating the script. When installing it for the first time, it most likely works out-of-the-box as the default settings will be used).

Good thing it failed, that gave me an idea how to disable a certain service: setting its instance to an empty string. Just need to handle that appropriately then.

Thanks! Tried it and it works (first wondered why it failed, so a note: one explicitly needs to set a teddit instance after updating the script. When installing it for the first time, it most likely works out-of-the-box as the default settings will be used). Good thing it failed, that gave me an idea how to disable a certain service: setting its instance to an empty string. Just need to handle that appropriately then.

ltguillaume commented 2020年11月28日 21:58:40 +01:00

Yeah I saw that, too, but I didn't know if you'd appreciate adding code for that. I would also like to be able to disable a service rewrite with an empty string, yeah!

Yeah I saw that, too, but I didn't know if you'd appreciate adding code for that. I would also like to be able to disable a service rewrite with an empty string, yeah!

izzy commented 2020年11月28日 22:45:04 +01:00

I would also like to be able to disable a service rewrite with an empty string, yeah!

Well, you can – just update to v1.5.1 😃

Besides, there was another request at Greasyfork to toggle the tumbnails for Teddit. I'm not a Reddit user, so I wouldn't know what to look for when checking whether the code works – but if you wish to address that, too, with another PR, just take a look how the Invidious proxy is toggled and introduce a corresponding tedThumb variable. The URL parameter would be showThumbs=false.

> I would also like to be able to disable a service rewrite with an empty string, yeah! Well, you can – just update to v1.5.1 :smiley: Besides, there was [another request at Greasyfork](https://greasyfork.org/de/scripts/374833-yt2invidio/discussions/66899) to toggle the tumbnails for Teddit. I'm not a Reddit user, so I wouldn't know what to look for when checking whether the code works – but if you wish to address that, too, with another PR, just take a look how the Invidious proxy is toggled and introduce a corresponding `tedThumb` variable. The URL parameter would be `showThumbs=false`.

ltguillaume commented 2020年11月28日 23:44:20 +01:00

Haha, had already updated, confirmed working 👍

As for the thumbnails, reddit-lite was created for mobile use and thumbnails aren't really integrated into the UI nicely. That's different for teddit. I guess disabling thumbs was added to reddit-lite in order to save data and/or on-screen space or something, but I doubt that many users will use it. I'd say let's not put all kinds of rarely used features into the script.

Haha, had already updated, confirmed working 👍 As for the thumbnails, reddit-lite was created for mobile use and thumbnails aren't really integrated into the UI nicely. That's different for teddit. I guess disabling thumbs was added to reddit-lite in order to save data and/or on-screen space or something, but I doubt that many users will use it. I'd say let's not put all kinds of rarely used features into the script.

izzy commented 2020年11月29日 00:00:57 +01:00

Thanks for the insights – and full ack then!

Thanks for the insights – and full ack then!