Implement external data backup and restore #73

Nemris commented 2023年08月30日 11:12:12 +02:00

This data lives in the shared internal storage and isn't guaranteed to
exist for every app, therefore it's not mandatory to have an
extdata-*.tar file when restoring.

The logic in this PR will likely have to be reviewed when #72 is addressed.

This data lives in the shared internal storage and isn't guaranteed to exist for every app, therefore it's not mandatory to have an extdata-*.tar file when restoring. The logic in this PR will likely have to be reviewed when #72 is addressed.

Nemris commented 2023年09月11日 18:34:21 +02:00

The external data backup/restore is now opt-in, based on a new command-line flag.

The external data backup/restore is now opt-in, based on a new command-line flag.

ossilator commented 2024年05月28日 15:04:38 +02:00

"Fix fallback package check" is a somewhat unrelated fix and possibly deserves a separate MR.
the other commits should be squashed.

"Fix fallback package check" is a somewhat unrelated fix and possibly deserves a separate MR. the other commits should be squashed.

izzy commented 2024年05月28日 16:28:23 +02:00

Uh-oh... looks like some notification didn't reach me...

@Nemris is this ready to be merged? What's your thought on the suggestions by @ossilator? I'm fine keeping it together in one MR (now that's already in), going for "rebase + fast-forward". Haven't tested the changes yet, though. You've mentioned (still open) issue 72 for review; that still valid? It's been some time...

Uh-oh... looks like some notification didn't reach me... @Nemris is this ready to be merged? What's your thought on the suggestions by @ossilator? I'm fine keeping it together in one MR (now that's already in), going for "rebase + fast-forward". Haven't tested the changes yet, though. You've mentioned (still open) issue 72 for review; that still valid? It's been some time...

Nemris commented 2024年06月02日 15:59:57 +02:00

Uh-oh... looks like some notification didn't reach me...

@Nemris is this ready to be merged? What's your thought on the suggestions by @ossilator? I'm fine keeping it together in one MR (now that's already in), going for "rebase + fast-forward". Haven't tested the changes yet, though. You've mentioned (still open) issue 72 for review; that still valid? It's been some time...

To be honest, it's been quite a bit already - and I've lost touch with this MR. Is there enough demand to have this feature be implemented, or can we do without it?

Either way, it should still work as expected, but we should likely see whether it impacts #72 if you do merge it.

> Uh-oh... looks like some notification didn't reach me... > > @Nemris is this ready to be merged? What's your thought on the suggestions by @ossilator? I'm fine keeping it together in one MR (now that's already in), going for "rebase + fast-forward". Haven't tested the changes yet, though. You've mentioned (still open) issue 72 for review; that still valid? It's been some time... To be honest, it's been quite a bit already - and I've lost touch with this MR. Is there enough demand to have this feature be implemented, or can we do without it? Either way, it should still work as expected, but we should likely see whether it impacts #72 if you do merge it.

izzy commented 2024年06月16日 14:38:03 +02:00

Thanks @Nemris! And yes, it was quite a while ago. To me it was not clear if the PR was ready for merge ("The logic in this PR will likely have to be reviewed when #72 is addressed"), so I waited for a signal – and then forgot 🙈 So what is the status now? Testing needed – or ready for merge? Maybe @ossilator wants to try if it works as expected before we merge?

Thanks @Nemris! And yes, it was quite a while ago. To me it was not clear if the PR was ready for merge ("The logic in this PR will likely have to be reviewed when #72 is addressed"), so I waited for a signal – and then forgot 🙈 So what is the status now? Testing needed – or ready for merge? Maybe @ossilator wants to try if it works as expected before we merge?

izzy commented 2025年04月17日 13:54:29 +02:00

@Nemris it seems we get lost here again... There was nothing implemented yet for adopted storage, so this should at least not break that. Maybe we can finalize this before addressing the other one? @ossilator what do you think?

@Nemris it seems we get lost here again... There was nothing implemented yet for adopted storage, so this should at least not break that. Maybe we can finalize this **before** addressing the other one? @ossilator what do you think?

ossilator commented 2025年04月17日 18:02:39 +02:00

upon a quick look i'd say i stand by my comment, because i find good commit hygiene important.

i've lost interest beyond that; my current rom comes with seedvault, which seems adequate.

upon a quick look i'd say i stand by my comment, because i find good commit hygiene important. i've lost interest beyond that; my current rom comes with seedvault, which seems adequate.

Nemris commented 2025年04月19日 14:26:10 +02:00

@izzy It's been a fair while and I myself have not much use for this feature, as it seems it targets what's pretty much an edge case. I've seen only one app store its actual data in /sdcard/Android, so I wonder if the MR is necessary.

(Regarding the fix @ossilator pointed out, I might look into working on a separate MR as time allows and then rebase this one on top of the main branch if it needs to be kept open.)

@izzy It's been a fair while and I myself have not much use for this feature, as it seems it targets what's pretty much an edge case. I've seen only one app store its actual data in `/sdcard/Android`, so I wonder if the MR is necessary. (Regarding the fix @ossilator pointed out, I might look into working on a separate MR as time allows and then rebase this one on top of the main branch if it needs to be kept open.)

izzy commented 2025年04月19日 17:45:19 +02:00

Thanks @Nemris! Then let's leave this one open for now. I'll leave it to you two to decide if it shall be rebased and merged later, or simply closed.

@ossilator speaking about Seedvault, out of curiosity: is it meanwhile possible to restore a single app and/or its data "on demand"? That was what I missed when I looked into it the last time (which admittedly is quite a while ago).

Thanks @Nemris! Then let's leave this one open for now. I'll leave it to you two to decide if it shall be rebased and merged later, or simply closed. @ossilator speaking about Seedvault, out of curiosity: is it meanwhile possible to restore a single app and/or its data "on demand"? That was what I missed when I looked into it the last time (which admittedly is quite a while ago).

ossilator commented 2025年04月20日 09:01:54 +02:00

yes, you can select it from the list.
the whole process was a bit flubbed, though - it didn't accumulate the incremental backups, and apps not installed through the play store needed an extra step. i also had to set up a web(-dav) server on my pc to get the data back to the blank phone. so a bit disappointing overall, but adequate for me.

yes, you can select it from the list. the whole process was a bit flubbed, though - it didn't accumulate the incremental backups, and apps not installed through the play store needed an extra step. i also had to set up a web(-dav) server on my pc to get the data back to the blank phone. so a bit disappointing overall, but adequate for me.

This pull request can be merged automatically.

You are not authorized to merge this pull request.