add acepted suggestions to shell history on Nushell/PowerShell #37

kiara commented 2026年04月10日 12:55:59 +02:00

This makes these match the existing behavior for Bash, Zsh, and Fish.

closes #36.

dsisclaimer i used a coding agent in the creation of this patch.

This makes these match the existing behavior for Bash, Zsh, and Fish. closes #36. dsisclaimer i used a coding agent in the creation of this patch.

iff commented 2026年04月10日 13:41:19 +02:00

Seems working!

Seems working!

iff commented 2026年04月17日 01:00:16 +02:00

Didn't seem to work in nushell with retries. Probably it generated an output like:

{ "cd": "{{ cd }}", "command": "{{ command }}" }
{ "cd": "{{ cd }}", "command": "{{ command }}" }

Which is not a valid json. e23d521a4a should fix it.

Also, nushell seems to add the input command at the end of the execution? The first entry back in the history is the f and not accepted suggestion.

Didn't seem to work in nushell with retries. Probably it generated an output like: ```json { "cd": "{{ cd }}", "command": "{{ command }}" } { "cd": "{{ cd }}", "command": "{{ command }}" } ``` Which is not a valid json. e23d521a4a should fix it. Also, nushell seems to add the input command at the end of the execution? The first entry back in the history is the `f` and not accepted suggestion.

kiara commented 2026年04月21日 19:53:53 +02:00

yeah, i hadn't found a way to append to nushell's reedline to get the order right when pressing up unfortunately :(

yeah, i hadn't found a way to append to nushell's reedline to get the order right when pressing up unfortunately :(