8
0
Fork
You've already forked gitops
0

Github commit status integration #30

Open
daurnimator wants to merge 1 commit from daurnimator/github-commit-status into master
pull from: daurnimator/github-commit-status
merge into: hashbang-sh:master
hashbang-sh:master
hashbang-sh:renovate/redis-7.x
hashbang-sh:renovate/quay.io-keycloak-keycloak-25.x
hashbang-sh:renovate/postgrest-postgrest-12.x
hashbang-sh:renovate/kiwigrid-k8s-sidecar-1.x
hashbang-sh:renovate/quay.io-argoproj-argocd-2.x
hashbang-sh:renovate/argoproj-argo-cd-2.x
hashbang-sh:renovate/cert-manager-1.x
hashbang-sh:renovate/quay.io-keycloak-keycloak-24.x
hashbang-sh:renovate/ghcr.io-dexidp-dex-2.x
hashbang-sh:renovate/registry.k8s.io-external-dns-external-dns-0.x
hashbang-sh:jitsi
hashbang-sh:argocd/openpgp-signatures
hashbang-sh:drgrove/openpgp-ca
hashbang-sh:ingress-nginx
hashbang-sh:add-lrvick
hashbang-sh:gpg-signed
hashbang-sh:persist-prometheus-timeseries
hashbang-sh:argocd-deploy-gpg-pub-key
hashbang-sh:docs/removing-admins
hashbang-sh:drgrove/loki-logging
hashbang-sh:drGrove/nginx-ingress-helm-stable
hashbang-sh:nginx-ingress-proxy-protocol
hashbang-sh:ingress-is-messed-up
daurnimator commented 2020年06月13日 17:26:01 +02:00 (Migrated from github.com)
Copy link

github apps need an extra dance. https://github.com/argoproj-labs/argocd-notifications/issues/99

github apps need an extra dance. https://github.com/argoproj-labs/argocd-notifications/issues/99
KellerFuchs commented 2023年05月08日 11:59:59 +02:00 (Migrated from github.com)
Copy link

@daurnimator I'd like to work on this, could you rebase and re-encrypt argocd/argocd-notifications/secret.enc.yaml ?

@daurnimator I'd like to work on this, could you rebase and re-encrypt `argocd/argocd-notifications/secret.enc.yaml` ?
KellerFuchs commented 2023年05月08日 12:00:13 +02:00 (Migrated from github.com)
Copy link

or @RyanSquared I guess? ;3

or @RyanSquared I guess? ;3
KellerFuchs commented 2023年05月13日 14:46:15 +02:00 (Migrated from github.com)
Copy link

@daurnimator Thanks! Looks like you even updated it to use the upstream support instead of a custom 'cron' job and ruby script. <3

If I follow correctly, argocd-notifications-cm.patch.yml is applied to applicationset-generator.yml, and so the settings under template will apply to all applications deployed on argocd?

TBH this seems good to me. What's holding it as a work-in-progress?
We may want to have argo run dry-runs on our PR branches, but I can try and make a follow-up PR later.

@daurnimator Thanks! Looks like you even updated it to use the [upstream support](https://argo-cd.readthedocs.io/en/stable/operator-manual/notifications/services/github/) instead of a custom 'cron' job and ruby script. <3 If I follow correctly, `argocd-notifications-cm.patch.yml` is applied to `applicationset-generator.yml`, and so the settings under `template` will apply to all applications deployed on argocd? TBH this seems good to me. What's holding it as a work-in-progress? We may want to have argo run dry-runs on our PR branches, but I can try and make a follow-up PR later.
daurnimator commented 2023年05月15日 05:09:53 +02:00 (Migrated from github.com)
Copy link

TBH this seems good to me. What's holding it as a work-in-progress?

Completely untested. Though it might work as-is.

> TBH this seems good to me. What's holding it as a work-in-progress? Completely untested. Though it might work as-is.
KellerFuchs commented 2023年05月15日 15:04:34 +02:00 (Migrated from github.com)
Copy link

TBH this seems good to me. What's holding it as a work-in-progress?

Completely untested. Though it might work as-is.

OK. Do we (currently) have a way to test it other than deploying it?

If not, I'd be fine with deploying as-is (and being sad we are testing in production)

> > TBH this seems good to me. What's holding it as a work-in-progress? > > Completely untested. Though it might work as-is. OK. Do we (currently) have a way to test it *other* than deploying it? If not, I'd be fine with deploying as-is (and being sad we are testing in production)
daurnimator commented 2023年05月30日 13:36:37 +02:00 (Migrated from github.com)
Copy link

OK. Do we (currently) have a way to test it other than deploying it?

not really; other than spinning up a local cluster and trying there.... but that then needs it's whole own overlay with it's own github app etc. Too much to bother with IMO.

If not, I'd be fine with deploying as-is (and being sad we are testing in production)

Sure. I'll take the PR out of draft

> OK. Do we (currently) have a way to test it _other_ than deploying it? not really; other than spinning up a local cluster and trying there.... but that then needs it's whole own overlay with it's own github app etc. Too much to bother with IMO. > If not, I'd be fine with deploying as-is (and being sad we are testing in production) Sure. I'll take the PR out of draft
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin daurnimator/github-commit-status:daurnimator/github-commit-status
git switch daurnimator/github-commit-status

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff daurnimator/github-commit-status
git switch daurnimator/github-commit-status
git rebase master
git switch master
git merge --ff-only daurnimator/github-commit-status
git switch daurnimator/github-commit-status
git rebase master
git switch master
git merge --no-ff daurnimator/github-commit-status
git switch master
git merge --squash daurnimator/github-commit-status
git switch master
git merge --ff-only daurnimator/github-commit-status
git switch master
git merge daurnimator/github-commit-status
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hashbang-sh/gitops!30
Reference in a new issue
hashbang-sh/gitops
No description provided.
Delete branch "daurnimator/github-commit-status"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?