8
0
Fork
You've already forked gitops
0

argocd: Add GPG public key for user import #25

Open
drGrove wants to merge 1 commit from argocd-deploy-gpg-pub-key into master
pull from: argocd-deploy-gpg-pub-key
merge into: hashbang-sh:master
hashbang-sh:master
hashbang-sh:renovate/redis-7.x
hashbang-sh:renovate/quay.io-keycloak-keycloak-25.x
hashbang-sh:renovate/postgrest-postgrest-12.x
hashbang-sh:renovate/kiwigrid-k8s-sidecar-1.x
hashbang-sh:renovate/quay.io-argoproj-argocd-2.x
hashbang-sh:renovate/argoproj-argo-cd-2.x
hashbang-sh:renovate/cert-manager-1.x
hashbang-sh:renovate/quay.io-keycloak-keycloak-24.x
hashbang-sh:renovate/ghcr.io-dexidp-dex-2.x
hashbang-sh:renovate/registry.k8s.io-external-dns-external-dns-0.x
hashbang-sh:jitsi
hashbang-sh:argocd/openpgp-signatures
hashbang-sh:drgrove/openpgp-ca
hashbang-sh:ingress-nginx
hashbang-sh:add-lrvick
hashbang-sh:gpg-signed
hashbang-sh:persist-prometheus-timeseries
hashbang-sh:docs/removing-admins
hashbang-sh:drgrove/loki-logging
hashbang-sh:drGrove/nginx-ingress-helm-stable
hashbang-sh:nginx-ingress-proxy-protocol
hashbang-sh:ingress-is-messed-up
drGrove commented 2020年06月08日 12:26:21 +02:00 (Migrated from github.com)
Copy link
No description provided.
daurnimator (Migrated from github.com) reviewed 2020年06月08日 12:26:21 +02:00
RyanSquared (Migrated from github.com) reviewed 2020年06月08日 12:26:21 +02:00
daurnimator commented 2020年06月08日 13:13:42 +02:00 (Migrated from github.com)
Copy link

Although this is useful, its sort of a dangling artifact.
Can we find a better place for it?

Although this is useful, its sort of a dangling artifact. Can we find a better place for it?
daurnimator (Migrated from github.com) requested changes 2020年06月09日 04:54:48 +02:00
daurnimator (Migrated from github.com) commented 2020年06月09日 04:54:33 +02:00
Copy link

this should be extras (with an s).

However I like the current setup that everything is an app. Can we put it in the argocd folder? or the root?

this should be extras (with an s). However I like the current setup that everything is an app. Can we put it in the argocd folder? or the root?
RyanSquared (Migrated from github.com) reviewed 2020年06月20日 07:26:34 +02:00
@ -13,0 +14,4 @@
### Dependencies
1. kubectl
RyanSquared (Migrated from github.com) commented 2020年06月20日 07:26:34 +02:00
Copy link

should add in kustomize as we're not using the builtin kubectl kustomize.

should add in kustomize as we're not using the builtin `kubectl kustomize`.
daurnimator commented 2020年06月21日 06:52:57 +02:00 (Migrated from github.com)
Copy link

@drGrove see earlier comment:

I like the current setup that each folder in the root is an app. Can we put the key in the argocd folder? or the root?

@drGrove see earlier comment: I like the current setup that each folder in the root is an app. Can we put the key in the argocd folder? or the root?
drGrove commented 2020年06月21日 07:08:27 +02:00 (Migrated from github.com)
Copy link

@drGrove see earlier comment:

I like the current setup that each folder in the root is an app. Can we put the key in the argocd folder? or the root?

I think I had it there before. I can put it in the folder, should it be in a subfolder of argocd?

> @drGrove see earlier comment: > > I like the current setup that each folder in the root is an app. Can we put the key in the argocd folder? or the root? I think I had it there before. I can put it in the folder, should it be in a subfolder of argocd?
daurnimator commented 2020年06月21日 07:14:31 +02:00 (Migrated from github.com)
Copy link

I think I had it there before. I can put it in the folder, should it be in a subfolder of argocd?

idea: what about as an annotation/label on the deploy-key resource itself?

or can we get SOPS to not encrypt a specific field?

> I think I had it there before. I can put it in the folder, should it be in a subfolder of argocd? idea: what about as an annotation/label on the deploy-key resource itself? or can we get SOPS to not encrypt a specific field?
drGrove commented 2020年10月07日 06:56:40 +02:00 (Migrated from github.com)
Copy link

I think I had it there before. I can put it in the folder, should it be in a subfolder of argocd?

idea: what about as an annotation/label on the deploy-key resource itself?

or can we get SOPS to not encrypt a specific field?

SOPS will only encrypt fields we tell it to. But normally that's data|stringData.
As far as labels/annotations, they have a max limit which I think this would would blow through

> > I think I had it there before. I can put it in the folder, should it be in a subfolder of argocd? > > idea: what about as an annotation/label on the deploy-key resource itself? > > or can we get SOPS to not encrypt a specific field? SOPS will only encrypt fields we tell it to. But normally that's `data|stringData`. As far as labels/annotations, they have a max limit which I think this would would blow through
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin argocd-deploy-gpg-pub-key:argocd-deploy-gpg-pub-key
git switch argocd-deploy-gpg-pub-key

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff argocd-deploy-gpg-pub-key
git switch argocd-deploy-gpg-pub-key
git rebase master
git switch master
git merge --ff-only argocd-deploy-gpg-pub-key
git switch argocd-deploy-gpg-pub-key
git rebase master
git switch master
git merge --no-ff argocd-deploy-gpg-pub-key
git switch master
git merge --squash argocd-deploy-gpg-pub-key
git switch master
git merge --ff-only argocd-deploy-gpg-pub-key
git switch master
git merge argocd-deploy-gpg-pub-key
git push origin master
Sign in to join this conversation.
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hashbang-sh/gitops!25
Reference in a new issue
hashbang-sh/gitops
No description provided.
Delete branch "argocd-deploy-gpg-pub-key"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?