8
0
Fork
You've already forked gitops
0

Initial stab at Jitsi #218

Merged
michaelssingh merged 5 commits from jitsi into master 2023年10月27日 05:56:11 +02:00
michaelssingh commented 2023年09月18日 17:42:03 +02:00 (Migrated from github.com)
Copy link

Deploy

Before you deploy the first time, create a namespace to deploy jitsi to:

kubectl create namespace jitsi

Next create a secret with your secret password (replace my-password with some random strings):

kubectl create secret generic jitsi-config -n jitsi --from-literal=JICOFO_COMPONENT_SECRET=my-password --from-literal=JICOFO_AUTH_PASSWORD=my-password --from-literal=JVB_AUTH_PASSWORD=my-password
## Deploy Before you deploy the first time, create a namespace to deploy jitsi to: kubectl create namespace jitsi Next create a secret with your secret password (replace `my-password` with some random strings): kubectl create secret generic jitsi-config -n jitsi --from-literal=JICOFO_COMPONENT_SECRET=my-password --from-literal=JICOFO_AUTH_PASSWORD=my-password --from-literal=JVB_AUTH_PASSWORD=my-password
RyanSquared (Migrated from github.com) requested changes 2023年09月19日 23:51:20 +02:00
RyanSquared (Migrated from github.com) commented 2023年09月19日 23:47:45 +02:00
Copy link

This should be a ClusterIP since nodes should be considered ephemeral. You can use a UDP service with Ingress NGINX: https://kubernetes.github.io/ingress-nginx/user-guide/exposing-tcp-udp-services/ https://github.com/hashbang/gitops/blob/master/ingress-nginx/tcp-services-cm.yaml and https://github.com/hashbang/gitops/blob/master/ingress-nginx/controller/resources.yaml#L17

You can include the changes to the ingress-nginx configuration in this PR to allow using Ingress NGINX for UDP inbound connections. DNS will also be managed automatically for this, since it's already done by the Ingress resource.

This should be a ClusterIP since nodes should be considered ephemeral. You can use a UDP service with Ingress NGINX: https://kubernetes.github.io/ingress-nginx/user-guide/exposing-tcp-udp-services/ https://github.com/hashbang/gitops/blob/master/ingress-nginx/tcp-services-cm.yaml and https://github.com/hashbang/gitops/blob/master/ingress-nginx/controller/resources.yaml#L17 You can include the changes to the ingress-nginx configuration in this PR to allow using Ingress NGINX for UDP inbound connections. DNS will also be managed automatically for this, since it's already done by the Ingress resource.
RyanSquared (Migrated from github.com) commented 2023年09月19日 23:43:33 +02:00
Copy link

^ this would probably be prosody instead of localhost.

^ this would probably be `prosody` instead of `localhost`.
RyanSquared (Migrated from github.com) commented 2023年09月19日 23:45:16 +02:00
Copy link

This may need to be renamed: https://jitsi.github.io/handbook/docs/devops-guide/devops-guide-docker/#running-behind-nat-or-on-a-lan-environment

I'm not sure what the correct value would be, we shouldn't hardcode it.

This may need to be renamed: https://jitsi.github.io/handbook/docs/devops-guide/devops-guide-docker/#running-behind-nat-or-on-a-lan-environment I'm not sure what the correct value would be, we _shouldn't_ hardcode it.
@ -0,0 +25,4 @@
labels:
app.kubernetes.io/name:jicofo
spec:
containers:
RyanSquared (Migrated from github.com) commented 2023年09月19日 23:43:04 +02:00
Copy link

Each of these can be split into their own pod. You can reference pods in the same namespace for networking purposes by using the name of the pod (separate namespaces can use pod_name.namespace_name).

Each of these can be split into their own pod. You can reference pods in the same namespace for networking purposes by using the name of the pod (separate namespaces can use `pod_name.namespace_name`).
RyanSquared (Migrated from github.com) commented 2023年09月19日 23:51:11 +02:00
Copy link

Don't forget to make the Services point to the correct Pod when they are renamed.

Don't forget to make the Services point to the correct Pod when they are renamed.
@ -0,0 +137,4 @@
app.kubernetes.io/name:web
spec:
containers:
- name:web
RyanSquared (Migrated from github.com) commented 2023年09月19日 23:50:09 +02:00
Copy link

It looks like you're missing the containerPort configuration for Jitsi Web. See: https://kubernetes.io/docs/concepts/services-networking/service/#field-spec-ports

It looks like you're missing the containerPort configuration for Jitsi Web. See: https://kubernetes.io/docs/concepts/services-networking/service/#field-spec-ports
RyanSquared (Migrated from github.com) commented 2023年09月19日 23:50:47 +02:00
Copy link

Maybe the same for JVB?

Maybe the same for JVB?
@ -0,0 +19,4 @@
service:
name:web
port:
number:443
RyanSquared (Migrated from github.com) commented 2023年09月19日 23:48:42 +02:00
Copy link

I think this should be port 80, since I don't think the internal service would offer TLS out of the box?

I think this should be port 80, since I don't think the internal service would offer TLS out of the box?
daurnimator (Migrated from github.com) requested changes 2023年10月12日 13:01:57 +02:00
daurnimator (Migrated from github.com) left a comment
Copy link

Each of the sub-applications should probably be their own folder i.e.

  • prosody
  • jicofo
  • jvb

In each folder you can use a kustomization.yaml with commonLabels

Each of the sub-applications should probably be their own folder i.e. - prosody - jicofo - jvb In each folder you can use a kustomization.yaml with `commonLabels`
@ -0,0 +4,4 @@
labels:
service:jvb
name:jvb-udp
namespace:jitsi
daurnimator (Migrated from github.com) commented 2023年10月12日 13:00:20 +02:00
Copy link

Don't mention the namespace

Don't mention the namespace
@ -0,0 +33,4 @@
- name:XMPP_SERVER
value:prosody
- name:XMPP_DOMAIN
value:meet.jitsi
daurnimator (Migrated from github.com) commented 2023年10月12日 13:01:40 +02:00
Copy link

I assume these are not correct?

I assume these are not correct?
@ -0,0 +4,4 @@
name:jitsi-ingress
annotations:
cert-manager.io/cluster-issuer:"letsencrypt-prod"
external-dns.alpha.kubernetes.io/hostname:meet.hashbang.sh
daurnimator (Migrated from github.com) commented 2023年10月12日 13:00:09 +02:00
Copy link

You don't need this

You don't need this
RyanSquared (Migrated from github.com) reviewed 2023年10月13日 04:09:48 +02:00
@ -0,0 +33,4 @@
- name:XMPP_SERVER
value:prosody
- name:XMPP_DOMAIN
value:meet.jitsi
RyanSquared (Migrated from github.com) commented 2023年10月13日 04:09:47 +02:00
Copy link

It's an internal domain, I think it should be fine to be meet.jitsi, though this is the default so I'm not sure it has to be specified.

It's an internal domain, I think it should be fine to be `meet.jitsi`, though this is the default so I'm not sure it has to be specified.
lrvick commented 2023年10月27日 05:46:39 +02:00 (Migrated from github.com)
Copy link

merging as the only way to develop this further is live. Once we are live, we can do PRs for follow up changes.

I do not like this, but I don't like people being blocked more.

Let's find a better path for development cluster/workflows soon.

merging as the only way to develop this further is live. Once we are live, we can do PRs for follow up changes. I do not like this, but I don't like people being blocked more. Let's find a better path for development cluster/workflows soon.
Sign in to join this conversation.
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
hashbang-sh/gitops!218
Reference in a new issue
hashbang-sh/gitops
No description provided.
Delete branch "jitsi"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?