• Joined on 2025年09月27日
hahnjo approved guile/guile#178 2026年05月10日 20:33:29 +02:00
Fix SCM to int32/uint32 conversions for LLP64

LGTM, thanks for the update!

hahnjo suggested changes for guile/guile#178 2026年04月28日 21:04:03 +02:00
Fix SCM to int32/uint32 conversions for LLP64

Should be SCM_I_FIXNUM_BIT < 32, and the last two commits should logically go together.

hahnjo commented on pull request guile/guile#178 2026年04月28日 21:03:13 +02:00
Fix SCM to int32/uint32 conversions for LLP64

I think SCM_I_FIXNUM_BIT < 32 is the correct condition here: if it was equal to 32, we could just create an inum and be done. To make the link, you should probably squash the last two commits to...

hahnjo commented on pull request guile/guile#178 2026年04月28日 20:57:43 +02:00
Fix SCM to int32/uint32 conversions for LLP64
hahnjo approved guile/guile#174 2026年04月25日 15:59:30 +02:00
Overflow in INUM_LOSSLESSLY_CONVERTIBLE_TO_DOUBLE

LGTM, thanks for detailed explanations!

hahnjo approved guile/guile#147 2026年03月30日 08:39:06 +02:00
pointer truncation in object-address

LGTM!

hahnjo commented on issue guile/guile#56 2026年03月22日 21:04:11 +01:00
Guile main fails to build on Mingw64.
hahnjo commented on issue guile/guile#116 2026年03月22日 20:57:00 +01:00
Speeding up stage0

I missed at first that you tested "with prebuilt binaries"... For me, without the build time improves from 14m24s to 13m12s on my 8 core laptop processor. With prebuilt bytecode, it's 6m57s to 6m.

hahnjo commented on issue guile/guile#56 2026年03月22日 14:38:38 +01:00
Guile main fails to build on Mingw64.

Yes, I'm not convinced that all of this is necessary. Can we first take a step back and assess what is the current situation: Does Guile build or not? I'm only talking about make, not yet about...

hahnjo commented on pull request guile/guile#140 2026年03月22日 14:35:14 +01:00
WIP: build fixes for MinGW UCRT

This PR is, once again, a wild mix of "obviously correct" fixes (such as using scm_from_uintptr_t) and intricate changes in integers.c that I'm not sure are needed. Can these be split into...

hahnjo commented on pull request guile/guile#140 2026年03月22日 14:35:12 +01:00
WIP: build fixes for MinGW UCRT
hahnjo commented on pull request guile/guile#140 2026年03月22日 14:35:09 +01:00
WIP: build fixes for MinGW UCRT

This is incorrect because it's possible to build Guile with "normal" GMP on 64-bit Windows.

hahnjo commented on issue guile/guile#56 2026年03月21日 10:26:13 +01:00
Guile main fails to build on Mingw64.

@spk121 if you can share some more details about what doesn't compile, I may be able to help / make educated guesses of what's missing.

hahnjo commented on pull request guile/guile#134 2026年03月19日 08:35:24 +01:00
Default to use mini-gmp for correctness; add --disable-mini-gmp flag

AFAICT the configure-flags pass --enable-mini-gmp unconditionally, so you probably want to modify that as well?

hahnjo deleted branch copysign-GO32 from hahnjo/guile 2026年03月10日 19:21:51 +01:00
hahnjo deleted branch limb from hahnjo/guile 2026年03月10日 19:21:20 +01:00
hahnjo commented on pull request guile/guile#86 2026年03月06日 08:35:10 +01:00
mini-gmp: Use long long limb type for _WIN64
hahnjo pushed to limb at hahnjo/guile 2026年03月05日 19:37:07 +01:00
f27d10e6c8 mini-gmp: Use long long limb type for _WIN64
6012b75ac3 Keep unmodified version of mini-gmp
2ce0b76760 Remove verify of mp_limb_t in numbers.c
0fd9ee8fc9 fix: Macro hygiene issue with identifier resolution across modules.
3d324966ab fix: Segfault of writes to immutable bytevectors
Compare 13 commits »
hahnjo commented on pull request guile/guile#86 2026年03月05日 18:38:14 +01:00
mini-gmp: Use long long limb type for _WIN64
hahnjo commented on pull request guile/guile#86 2026年03月03日 19:02:01 +01:00
mini-gmp: Use long long limb type for _WIN64