1
0
Fork
You've already forked x48
0

Adding the parts needed to run x48 in a Docker container, for portability. #5

Merged
danwitt merged 1 commit from dockerize_x48_v1 into master 2020年02月11日 18:54:36 +01:00
danwitt commented 2020年02月10日 20:48:12 +01:00 (Migrated from github.com)
Copy link
No description provided.
gwh left a comment
Copy link

I know little about docker but I wonder if it's normal that your username (danwitt) appears in various places. Couldn't it be replaced by $HOME ?

I know little about docker but I wonder if it's normal that your username (danwitt) appears in various places. Couldn't it be replaced by $HOME ?
danwitt commented 2020年02月11日 18:49:33 +01:00 (Migrated from github.com)
Copy link

danwitt is the dockerhub repository that the built image resides in:

https://hub.docker.com/r/danwitt/x48

It's definitely cool with me if we host the built image in another
repository. I just didn't have a better place to put it. :)

Thanks,
Dan

On Tue, Feb 11, 2020, 10:07 AM gwenhael notifications@github.com wrote:

@gwenhael-le-moine commented on this pull request.

I know little about docker but I wonder if it's normal that your username
(danwitt) appears in various places. Couldn't it be replaced by $HOME ?

—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
https://github.com/gwenhael-le-moine/x48/pull/5?email_source=notifications&email_token=AIOSI5VVL2KTL5TU63Z6YQTRCLLNPA5CNFSM4KSUNSH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVCOCZI#pullrequestreview-356835685,
or unsubscribe
https://github.com/notifications/unsubscribe-auth/AIOSI5VVYTTC2J2J4OWJGQLRCLLNPANCNFSM4KSUNSHQ
.

danwitt is the dockerhub repository that the built image resides in: https://hub.docker.com/r/danwitt/x48 It's definitely cool with me if we host the built image in another repository. I just didn't have a better place to put it. :) Thanks, Dan On Tue, Feb 11, 2020, 10:07 AM gwenhael <notifications@github.com> wrote: > *@gwenhael-le-moine* commented on this pull request. > > I know little about docker but I wonder if it's normal that your username > (danwitt) appears in various places. Couldn't it be replaced by $HOME ? > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > <https://github.com/gwenhael-le-moine/x48/pull/5?email_source=notifications&email_token=AIOSI5VVL2KTL5TU63Z6YQTRCLLNPA5CNFSM4KSUNSH2YY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCVCOCZI#pullrequestreview-356835685>, > or unsubscribe > <https://github.com/notifications/unsubscribe-auth/AIOSI5VVYTTC2J2J4OWJGQLRCLLNPANCNFSM4KSUNSHQ> > . >
Owner
Copy link

Oh, ok. As I said I know little about docker... Looks fine to me then, I'll merge. Thanks.

Oh, ok. As I said I know little about docker... Looks fine to me then, I'll merge. Thanks.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
gwh/x48!5
Reference in a new issue
gwh/x48
No description provided.
Delete branch "dockerize_x48_v1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?