readevalprintloop/guile:add-srfi-244 into main This SRFI re-export the 'define-values' from (guile), aims to help
writing portable code.
Should I add a test suite for SRFI-244? (maybe copy from the original test suite of define-values).
@ -0,0 +22,4 @@
;;;
;;; Code:
(define-module (srfi srfi-244)
also add (cond-expand-provide (current-module) '(srfi-244))
@ -0,0 +23,4 @@
;;; Code:
(define-module (srfi srfi-244)
#:use-module (guile)
no needed
@ -0,0 +24,4 @@
(define-module (srfi srfi-244)
#:use-module (guile)
#:export (define-values))
#:re-export
All done in 47c06a071c (diff-739a6352bd)
e624ad2938
to 47c06a071c
47c06a071c
to e04446081e
e04446081e
to 2d3a2493e6
2d3a2493e6
to 6fe01450c0
@ -7875,0 +7877,4 @@
@subsection SRFI-244 - Multiple-value Definitions
@cindex SRFI-244
The implementation of this SRFI re-export the @code{define-values} form
nitpick: re-exports rather than re-export
Also add a period at the end of the sentence.
@annoyingusername wrote in #26 (comment):
Also add a period at the end of the sentence.
The end of sentence is on the next line
In your commit message, fix mentoin to Mention and supports to support.
@ -0,0 +25,4 @@
(define-module (srfi srfi-244)
#:re-export (define-values))
(cond-expand-provide (current-module) '(srfi-244))
If define-values is core Guile, shouldn't SRFI-244 be part of %cond-expand-features instead of using cond-expand-provide? See the comment in its definition in module/ice-9/boot-9.scm.
fair, fix in new commit. Thanks for catching this!
6fe01450c0
to fa287f3bfb
fa287f3bfb
to ecafef7928
ecafef7928
to 360672563e
@ -0,0 +20,4 @@
;;;
;;; This is an implementation of SRFI 244: Multiple-value Definitions.
;;;
;;; Code:
This should probably be:
;;; Commentary:
;;; This is an implementation of SRFI 244: Multiple-value Definitions.
;;; Code:
Other than that, it looks good to me!
360672563e
to 898d910cce
@ -40,0 +41,4 @@
Guile now provides syntax 'define-values' under the module (srfi
srfi-244). This syntax existed for a long time in the core of Guile,
export it in SRFI module can help writing portable code.
small grammar nitpick: exporting it in the SRFI module
Suggestion for the whole last line:
now it is also exported via srfi-244 to help writing portable code.
Aside from that it is ready to merge -- feel free to ping me in IRC once the grammar is fixed (in any way you choose) so I can merge.
Done in e5c4fb243c
898d910cce
to e5c4fb243c
Thank you! Merged.
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?