guile/guile
22
141
Fork
You've already forked guile
45

Cleanup the implementation of 'define-values'. #123

Closed
readevalprintloop wants to merge 1 commit from readevalprintloop/guile:rework-define-values into main
pull from: readevalprintloop/guile:rework-define-values
merge into: guile:main
guile:main
guile:wip-whippet
guile:wip-mingw-2025
guile:wip-elisp-rebased
guile:wip-exception-truncate
guile:wip-3.2
guile:wip-tailify
guile:wip-load-lang
guile:wip-lightening-riscv
guile:wip-cuirass-ci
guile:wip-mingw
guile:wip-modernize-autotools
guile:wip-tree-il-sourcev
guile:compile-to-js-merge
guile:wip-inlinable-exports
guile:branch_release-1-8
guile:mingw-guile-3.0
guile:use-minigmp
guile:excise-ltdl
guile:stable-2.2-wip-exception-truncate
guile:wip-vector-cleanup
guile:wip-replace-ltdl-with-gmodule
guile:stable-2.2
guile:wip-new-tagging-bis-broken
guile:wip-new-tagging
guile:lightening
guile:lightning
guile:wip-mingw-guile-2.2
guile:stable-2.0
guile:wip-lloda
guile:wip-cygwin-guile-2.2
guile:wip-itimer-checks
guile:lloda-squash1
guile:lloda-squash0
guile:lloda-array-support
guile:wip-ethreads
guile:wip-elisp
guile:wip-stime
guile:wip-streams
guile:r7rs-wip
guile:lloda-array-cleanup
guile:cky-hygienic-macros
guile:lua
guile:wip-retagging
guile:ttn-back-in-the-saddle
guile:wip-raeburn-misc
guile:wip-threaded-http-server
guile:wip-finalizers
guile:wip-threads-and-fork
guile:wip-compiler
guile:nan-boxing
guile:wip-bpt-elisp
guile:historical/wip-1-8-mingw-build
guile:wip-sassy
guile:wip-nj-locks-nc
guile:wip-nj-thread-safety
guile:branch_release-1-6
guile:branch_release-1-4

With the help of hygiene top-level identifier and 0fd9ee8fc9 we can finally cleanup these XXX in the implementation of define-values.

  • module/ice-9/boot-9.scm (define-values): Remove stale
    generate-temporaries workaround for missing hygiene top-level identifier.
With the help of hygiene top-level identifier and https://codeberg.org/guile/guile/commit/0fd9ee8fc9e3e1a7fa9dd91b78e4c3ba2b870f39 we can finally cleanup these `XXX` in the implementation of `define-values`. * module/ice-9/boot-9.scm (define-values): Remove stale generate-temporaries workaround for missing hygiene top-level identifier.
Collaborator
Copy link

Manually merged in 055a393233.

I added some regression tests for it.

Manually merged in 055a393233d712d57f7867a55acd8554e090535d. I added some regression tests for it.
old closed this pull request 2026年03月10日 20:21:45 +01:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Contribution Welcomed
A PR is most welcome to help
Discussion
More of a discussion than an issue
Good First Issue
An issue that is good for new contributors
Help Wanted
Help is needed from someone
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Windows
🪟 related.
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
guile/guile!123
Reference in a new issue
guile/guile
No description provided.
Delete branch "readevalprintloop/guile:rework-define-values"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?