guile/guile
22
141
Fork
You've already forked guile
45

srfi-19: date->string: Fix ~I for the date with 0 as hour. #103

Manually merged
old merged 1 commit from readevalprintloop/guile:fix-date-I into main 2026年03月21日 01:51:08 +01:00

Fixes #102

In SRFI-19 specification and the Guile Manual, ~I directive in
'date->string' will always print time hours as number in range of 01 to
12. However, current implmentation will print 00:00 as "00", this patch
will make it print "12" instead.

  • module/srfi/srfi-19.scm (directives): In the callback procedure of #\I,
    first check whether hour is zero, print 12 if so.
  • test-suite/tests/srfi-19.test: Add some tests for ~I directive.
  • NEWS: Mention bug fixes.
Fixes #102 In SRFI-19 specification and the Guile Manual, ~I directive in 'date->string' will always print time hours as number in range of 01 to 12. However, current implmentation will print 00:00 as "00", this patch will make it print "12" instead. * module/srfi/srfi-19.scm (directives): In the callback procedure of #\I, first check whether hour is zero, print 12 if so. * test-suite/tests/srfi-19.test: Add some tests for ~I directive. * NEWS: Mention bug fixes.
old requested review from old 2026年03月20日 19:41:53 +01:00
Collaborator
Copy link

Is this ready to be merged? I see that it was force-pushed 4 hours ago.

Is this ready to be merged? I see that it was force-pushed 4 hours ago.
Author
Contributor
Copy link

@old wrote in #103 (comment):

Is this ready to be merged? I see that it was force-pushed 4 hours ago.

Yes, I have added the fix of ~l and polished the commit message.

@old wrote in https://codeberg.org/guile/guile/pulls/103#issuecomment-11860245: > Is this ready to be merged? I see that it was force-pushed 4 hours ago. Yes, I have added the fix of `~l` and polished the commit message.
old manually merged commit 3657d3ffb9 into main 2026年03月21日 01:51:08 +01:00
Sign in to join this conversation.
No reviewers
old
Labels
Clear labels
Compat/Breaking
Breaking change that won't be backward compatible
Contribution Welcomed
A PR is most welcome to help
Discussion
More of a discussion than an issue
Good First Issue
An issue that is good for new contributors
Help Wanted
Help is needed from someone
Kind/Bug
Something is not working
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Windows
🪟 related.
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
guile/guile!103
Reference in a new issue
guile/guile
No description provided.
Delete branch "readevalprintloop/guile:fix-date-I"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?