3
25
Fork
You've already forked fpdf
10

fixed rendering bug for th, zh, ja #81

Open
daksh-sehgal wants to merge 1 commit from daksh-sehgal/main into main
pull from: daksh-sehgal/main
merge into: go-pdf:main
go-pdf:main
daksh-sehgal commented 2024年07月19日 18:52:06 +02:00 (Migrated from github.com)
Copy link

Fixes issue #80 by not excluding Chinese origin characters when calling SplitText(). Also fixes a rendering bug with zero width characters (found in languages like Thai).

Fixes issue #80 by not excluding Chinese origin characters when calling SplitText(). Also fixes a rendering bug with zero width characters (found in languages like Thai).
Kohirus commented 2024年08月13日 04:57:16 +02:00 (Migrated from github.com)
Copy link

This fix is great, but there is a problem that if the text contains Spaces, it will force line breaks.

This fix is great, but there is a problem that if the text contains Spaces, it will force line breaks.
Kohirus commented 2024年08月13日 08:50:07 +02:00 (Migrated from github.com)
Copy link

I found the source of the problem, commented out the following in the MulitCell(), as well as the SplitText() and write(). Why do spaces need to be wrapped, maybe some languages ​​require this?

ifc==' '{sep=ils=lns++}
I found the source of the problem, commented out the following in the `MulitCell()`, as well as the `SplitText()` and `write()`. Why do spaces need to be wrapped, maybe some languages ​​require this? ```golang if c == ' ' { sep = i ls = l ns++ } ```
sbinet commented 2024年09月11日 10:11:42 +02:00 (Migrated from github.com)
Copy link

thanks for the PR. (and apologies for the belated answer)

could you add a testcase to this PR ?
(perhaps also adding a testcase exercizing what @Kohirus mentioned ?)

thanks again.

thanks for the PR. (and apologies for the belated answer) could you add a testcase to this PR ? (perhaps also adding a testcase exercizing what @Kohirus mentioned ?) thanks again.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin daksh-sehgal/main:daksh-sehgal/main
git switch daksh-sehgal/main

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch main
git merge --no-ff daksh-sehgal/main
git switch daksh-sehgal/main
git rebase main
git switch main
git merge --ff-only daksh-sehgal/main
git switch daksh-sehgal/main
git rebase main
git switch main
git merge --no-ff daksh-sehgal/main
git switch main
git merge --squash daksh-sehgal/main
git switch main
git merge --ff-only daksh-sehgal/main
git switch main
git merge daksh-sehgal/main
git push origin main
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
go-pdf/fpdf!81
Reference in a new issue
go-pdf/fpdf
No description provided.
Delete branch "daksh-sehgal/main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?