No description provided.
gnoblet
commented 2026年02月07日 17:35:31 +01:00
gnoblet
added 48 commits 2026年02月07日 17:35:31 +01:00
- Removed outdated tests for `add_font_bunny` and replaced with new tests for `as_CacheEntryList`, `as_FontProvider`, and other utility functions. - Added tests for cache operations including `cache_write`, `cache_read`, `cache_remove`, and `cache_clean`. - Introduced tests for font conversion functions and validation of provider helpers. - Implemented tests for error handling in font downloading and file path generation. - Ensured all new tests validate expected behaviors and error conditions for font management.
Relax S7 property types for conversion and conversion_ext to class_any with manual validation
011e3c201b
Refactor FontProvider tests to remove as_FontProvider function and validate fields directly
bbbb3b307f
Refactor register_from_download to use S7 FontProvider, CacheMeta, and CacheEntryList APIs
4ec3bd8451
- Replace provider list with S7 `FontProvider` object (with input validation) - Use `bold.wt` for bold variant downloads instead of reusing `regular.wt` - Switch from `new_cache_entry`/`cache_set` to `CacheMeta`, `cache_read`/`cache_write`, and `CacheEntryList` APIs - Improve bolditalic fallback chain (bold → italic → regular) - Update documentation to reflect new types and terminology (registry → cache)
- Replace `provider_l` parameter with `provider` of class `FontProvider` - Add S7 class validation check at function entry - Access provider fields via `@` slot syntax instead of dollar list access - Simplify control flow: cleaner download path selection, conversion handling, and final return - Improve warning messages to include family/weight/style context - Remove redundant intermediate file cleanup and dead code
Refactor add_font: extract string validation to helper, clean up cache lookup logic, and improve messaging
5abdf24517
Uncomment and clean up preview_font function with improved formatting and clearer fallback labels
349f12ae28
Refactor tests to use CacheEntry/CacheEntryList and FontProvider objects; add test helpers and utils tests
5db8b50a23
Add check for 'showtext' namespace in preview_font function to ensure proper font rendering
d6004655ca
Fix formatting of weight labels in preview_font function and add missing import statement
9c9cf92de3
Fix typographical errors in allowed character descriptions in assert_pattern_with_ext function
435c11cb3d
Remove redundant details from cache.R documentation and update parameter description for cache_remove function
87ce864af2
gnoblet
merged commit bbcba2884f into main 2026年02月07日 17:35:42 +01:00
gnoblet
referenced this pull request from a commit 2026年02月07日 17:35:42 +01:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
bug
Something is not working
contribution welcome
Contributions are very welcome, get started here
duplicate
This issue or pull request already exists
enhancement
New feature
good first issue
Interested in contributing? Get started here.
help wanted
Need some help
invalid
Something is wrong
question
More information is needed
upstream
Related to an upstream repository, already reported there
No labels
bug
contribution welcome
duplicate
enhancement
good first issue
help wanted
invalid
question
upstream
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
gnoblet/AddFonts!2
Loading...
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "dev"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?