• Joined on 2025年04月29日
gekeleda commented on pull request comaps/comaps#4031 2026年07月10日 19:29:13 +02:00
WIP: [generator] Add region border triangle generation

Squashed and clang-formatted ✅

gekeleda pushed to generator_triangles_packed at comaps/comaps 2026年07月10日 19:15:01 +02:00
307ae5c248
 [data][generator] Regenerated packed_polygons.bin with triangles
65680bfff0
 [generator] Add region border triangle generation
Compare 2 commits »
gekeleda pushed to generator_triangles_packed at comaps/comaps 2026年07月10日 19:08:28 +02:00
4aa5b0506d
 [data][generator] Regenerated packed_polygons.bin with triangles
0c8efdecb0
 [generator] Add region border triangle generation
Compare 2 commits »
gekeleda commented on pull request comaps/comaps#4031 2026年07月10日 18:47:29 +02:00
WIP: [generator] Add region border triangle generation

yeah I saw that too after pushing. I was meaning to do a clang anyways before squashing ^^

gekeleda commented on pull request comaps/comaps#4031 2026年07月10日 08:59:30 +02:00
WIP: [generator] Add region border triangle generation

Reproduced and fixed, just to be save I changed everything related to the original country polygons to be exactly the same as before. Will regenerate and squash later

gekeleda pushed to generator_triangles_packed at comaps/comaps 2026年07月10日 08:57:37 +02:00
c586459d71 [core] Refactor border triangle gen
gekeleda commented on pull request comaps/comaps#4031 2026年07月10日 08:54:45 +02:00
WIP: [generator] Add region border triangle generation

Done

gekeleda commented on pull request comaps/comaps#4031 2026年07月10日 08:54:22 +02:00
WIP: [generator] Add region border triangle generation

Agree, changed this and also the later if (!reader.IsExist)... to CHECKs

gekeleda commented on pull request comaps/comaps#4031 2026年07月10日 08:50:05 +02:00
WIP: [generator] Add region border triangle generation

Okay so this cannot happen at all with the current code, simplifiedPolygons will always have at least one entry with the current code. I turned it into a CHECK same as the others, to prevent any...

gekeleda commented on pull request comaps/comaps#4031 2026年07月01日 23:31:41 +02:00
WIP: [generator] Add region border triangle generation

What do you mean by this exactly? Raise an exception? Yes would be better, will fix later along with the remaining thing above

gekeleda commented on pull request comaps/comaps#4031 2026年07月01日 23:29:31 +02:00
WIP: [generator] Add region border triangle generation

As it has been a while, I will need to look at this again more in detail when I find some time

gekeleda commented on pull request comaps/comaps#4031 2026年07月01日 23:27:21 +02:00
WIP: [generator] Add region border triangle generation

Good point, changed those to use CHECK

gekeleda commented on pull request comaps/comaps#4031 2026年07月01日 23:26:13 +02:00
WIP: [generator] Add region border triangle generation

Made this line LINFO and added another LINFO "[BORDERS_GENERATOR] done" log

gekeleda pushed to generator_triangles_packed at comaps/comaps 2026年07月01日 23:25:00 +02:00
70b7ed1dfb Change behavior to fail fast, enable high-level INFO logging
gekeleda pushed to generator_triangles_packed at comaps/comaps 2026年07月01日 23:21:46 +02:00
22ec59aee9 Change behavior to fail fast, enable high-level INFO logging
291f71a9d1 clang format
31fa67b9ef [generator]fix missing bracket & update packed_polygons
91ceced7f2 Use proper GeometryCodingParams and capture by value
3bf0b7f6f3 Add region border triangle generation
Compare 93 commits »
gekeleda pushed to generator_triangles_packed at comaps/comaps 2026年06月28日 11:25:08 +02:00
7036427fd0 clang format
2de65ad081 [generator]fix missing bracket & update packed_polygons
22433c32b1 Use proper GeometryCodingParams and capture by value
418f40d96c Add region border triangle generation
27b803c58a June release notes
Compare 221 commits »
gekeleda approved comaps/comaps#4582 2026年06月28日 09:37:29 +02:00
[WIP] [icons] Use less detailed train icons

LGTM, but maybe should wait for at least one more person to look at this in case there are strong opinions on the icons

gekeleda closed issue comaps/comaps#2792 2026年06月28日 08:47:30 +02:00
Rename "Rail Halt"