13
39
Fork
You've already forked forte
10

fix-unconfigured-conversation-setting #53

Merged
streams merged 6 commits from abanink/forte:fix-unconfigured-conversation-setting into dev 2025年12月01日 19:04:19 +01:00
Collaborator
Copy link

In case the 'conversation' setting on system and channel are not set, the result of the (1 - (1 - default system conversation setting)) results in "0", meaning that incoming messages in Inbox which are not recognized as 'conversation', will be silently dropped. This is what I have been seeing on my instance.

It seems to me the logic is wrong, so I changed it evaluate to "1" in this PR in case no configuration of the system nor channel conversation setting was made.
Please review.

In case the 'conversation' setting on system and channel are not set, the result of the (1 - (1 - default system conversation setting)) results in "0", meaning that incoming messages in Inbox which are not recognized as 'conversation', will be silently dropped. This is what I have been seeing on my instance. It seems to me the logic is wrong, so I changed it evaluate to "1" in this PR in case no configuration of the system nor channel conversation setting was made. Please review.
abanink deleted branch fix-unconfigured-conversation-setting 2025年12月03日 19:38:20 +01:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
fortified/forte!53
Reference in a new issue
fortified/forte
No description provided.
Delete branch "abanink/forte:fix-unconfigured-conversation-setting"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?