13
39
Fork
You've already forked forte
10

Include channel items in site search #30

Merged
streams merged 4 commits from abanink/forte:site_search_include_channel_items into dev 2025年06月01日 23:13:05 +02:00
Collaborator
Copy link

In a site search, I would personally like to see also matching items in my stream next to the other items on my site that I am authorized to see.

This PR attempts to bundle the 'site search' and 'channel search' logically, and updates the comment to reflect the strategy.

What's tested:

  • channel search still returns only own items
  • site search includes own channel items when logged in
  • when not logged in, no results if no items are public or public search is disabled

This PR needs a review to double-check that no edge cases would expose content unintended.

In a site search, I would personally like to see also matching items in my stream next to the other items on my site that I am authorized to see. This PR attempts to bundle the 'site search' and 'channel search' logically, and updates the comment to reflect the strategy. What's tested: - channel search still returns only own items - site search includes own channel items when logged in - when not logged in, no results if no items are public or public search is disabled This PR needs a review to double-check that no edge cases would expose content unintended.
Collaborator
Copy link

That looks good. Thanks.

That looks good. Thanks.
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
fortified/forte!30
Reference in a new issue
fortified/forte
No description provided.
Delete branch "abanink/forte:site_search_include_channel_items"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?