33
41
Fork
You've already forked website
54

improve attribution to derived CC licensed work, see #132 #544

Merged
earl-warren merged 1 commit from mahlzahn/fix_cc_attribution into main 2025年01月24日 12:22:40 +01:00 AGit
- see #132
Collaborator
Copy link

Preview ready: https://forgejo.codeberg.page/@pull_544/
https://forgejo.codeberg.page/@pull_544/.../adr/adr-map-federated-person/
https://forgejo.codeberg.page/@pull_544/.../threat-analysis-like-activity/
https://forgejo.codeberg.page/@pull_544/.../adr/adr-activity-for-like/
https://forgejo.codeberg.page/@pull_544/.../adr/adr-how-to-trigger-activities/
https://forgejo.codeberg.page/@pull_544/.../adr/adr-ddd-for-federation/

Preview ready: https://forgejo.codeberg.page/@pull_544/ https://forgejo.codeberg.page/@pull_544/.../adr/adr-map-federated-person/ https://forgejo.codeberg.page/@pull_544/.../threat-analysis-like-activity/ https://forgejo.codeberg.page/@pull_544/.../adr/adr-activity-for-like/ https://forgejo.codeberg.page/@pull_544/.../adr/adr-how-to-trigger-activities/ https://forgejo.codeberg.page/@pull_544/.../adr/adr-ddd-for-federation/
@ -25,2 +25,4 @@
license: z.string().optional(),
origin_url: z.string().url().optional(),
origin_author: z.string().optional(),
origin_title: z.string().optional(),
Owner
Copy link

Are these two properties currently used?

Are these two properties currently used?
Author
Member
Copy link

See forgejo/docs#1057.

See forgejo/docs#1057.
mahlzahn marked this conversation as resolved
viceice requested changes 2025年01月24日 11:36:17 +01:00
Dismissed
@ -10,0 +11,4 @@
let originLabel = 'this original source';
if (originURL != null) {
if (originTitle != null) {
originLabel = `"${originTitle}"`;
Owner
Copy link

wrong quotes, use " or "

wrong quotes, use `"` or `"`
mahlzahn marked this conversation as resolved
@ -14,3 +24,3 @@
<Icon name="tabler:history" class="w-4 h-4" />
<span class="ml-1 mr-1"
>This page's <a href={historyURL}>content</a> is available under the <a href={licenseURL}>{license}</a> license.
>This page’s <a href={historyURL}>content</a> is available under the <a href={licenseURL}>{license}</a> license.
Owner
Copy link

wrong quote, use '

wrong quote, use `'`
Author
Member
Copy link

Why wrong? Isn’t it better style to use the proper quotation marks? Anyhow, seems that both is OK. Fixed it with 4306605ac3..76dd5346c1.

Why wrong? Isn’t it better style to use the proper quotation marks? Anyhow, seems that both is OK. Fixed it with https://codeberg.org/forgejo/website/compare/4306605ac351eeccbde58ebc4f2541ef4595b886..76dd5346c134e014da28d88f42dfe5484e812709.
mahlzahn marked this conversation as resolved
mahlzahn force-pushed mahlzahn/fix_cc_attribution from 4306605ac3
All checks were successful
pr / preview (pull_request_target) Successful in 1m30s
to 76dd5346c1
All checks were successful
pr / preview (pull_request_target) Successful in 1m3s
2025年01月24日 11:53:50 +01:00 Compare

should this close #132? if yes add closes #132 to PR description

should this close #132? if yes add `closes #132` to PR description
Gusted left a comment
Copy link

lgtm, thanks!

lgtm, thanks!
Author
Member
Copy link

@viceice wrote in #544 (comment):

should this close #132? if yes add closes #132 to PR description

It is blocking forgejo/docs#1057, which will close it ;)

@viceice wrote in https://codeberg.org/forgejo/website/pulls/544#issuecomment-2615957: > should this close #132? if yes add `closes #132` to PR description It is blocking forgejo/docs#1057, which will close it ;)
Sign in to join this conversation.
No reviewers
Labels
Clear labels
404
Broken links or missing content
Accessibility
Accessibility
Blog post
Documentation
Forgejo Documentation
Internationalisation
i18n and l10n
User research - Accessibility
Requires input about accessibility features, likely involves user testing.
User research - Blocked
Do not pick as-is! We are happy if you can help, but please coordinate with ongoing redesign in this area.
User research - Community
Community features, such as discovering other people's work or otherwise feeling welcome on a Forgejo instance.
User research - Config (instance)
Instance-wide configuration, authentication and other admin-only needs.
User research - Errors
How to deal with errors in the application and write helpful error messages.
User research - Filters
How filter and search is being worked with.
User research - Future backlog
The issue might be inspiring for future design work.
User research - Git workflow
AGit, fork-based and new Git workflow, PR creation etc
User research - Labels
Active research about Labels
User research - Moderation
Moderation Featuers for Admins are undergoing active User Research
User research - Needs input
Use this label to let the User Research team know their input is requested.
User research - Notifications/Dashboard
Research on how users should know what to do next.
User research - Rendering
Text rendering, markup languages etc
User research - Repo creation
Active research about the New Repo dialog.
User research - Repo units
The repo sections, disabling them and the "Add more" button.
User research - Security
User research - Settings (in-app)
How to structure in-app settings in the future?
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Reference
forgejo/website!544
Reference in a new issue
forgejo/website
No description provided.
Delete branch "mahlzahn/fix_cc_attribution"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?