Upgrading from gitea is not as straightforward as currently stated #87

Eragon commented 2023年02月06日 00:13:38 +01:00

The installation/upgrade tutorial state this

Forgejo is a fully-compatible drop-in replacement for Gitea.
When migrating from Gitea to the Forgejo release with the same release number (eg from Gitea v1.18 to Forgejo v1.18), all that is necessary is to replace the Gitea binary with the Forgejo binary (or change the container image).
When upgrading to Forgejo from an older version of Gitea, please follow the upgrade instructions in the Gitea documentation.

But this is not true.
If you don't place the Forgejo binary as gitea but as forgejo like almost everyone will do.
This will break all existing hooks in all existing repos, because the hooks directly link back to the gitea binary.

I suggest that we add something like:

After migrating you should run the repair hooks task.

This issue was found at the same time as this one (I have a friend that had issues to migrate because of that)

The installation/upgrade tutorial state this ``` Forgejo is a fully-compatible drop-in replacement for Gitea. When migrating from Gitea to the Forgejo release with the same release number (eg from Gitea v1.18 to Forgejo v1.18), all that is necessary is to replace the Gitea binary with the Forgejo binary (or change the container image). When upgrading to Forgejo from an older version of Gitea, please follow the upgrade instructions in the Gitea documentation. ``` But this is not true. If you don't place the Forgejo binary as `gitea` but as `forgejo` like almost everyone will do. This will break all existing hooks in all existing repos, because the hooks directly link back to the gitea binary. I suggest that we add something like: ``` After migrating you should run the repair hooks task. ``` This issue was found at the same time as [this one ](https://codeberg.org/forgejo/forgejo/issues/326) (I have a friend that had issues to migrate because of that)

earl-warren commented 2023年02月06日 00:35:41 +01:00

This deserves an entry in the FAQ. Although a conservative admin will likely use the same name for the binary of an existing installation or make a hard link just in case, it is probably not uncommon to assume the file name of the binary is not inserted in various unexpected places that make it difficult to rename it or move it around.

This deserves an entry in the FAQ. Although a conservative admin will likely use the same name for the binary of an existing installation or make a hard link just in case, it is probably not uncommon to assume the file name of the binary is not inserted in various unexpected places that make it difficult to rename it or move it around.

KaKi87 commented 2023年02月06日 01:08:39 +01:00

Actually, this point is also valid when upgrading from a Forgejo version to another or from a Gitea version to another, because of version numbers in binary names.

I guess renaming is an option, but then you loose the simple ability to know which Forgejo version you're running using ls.

So I use a symlink instead. When updating, I do this :

aria2c <binary>
rm <symlink>
ln -s <binary> <symlink>
./<binary>

Which is why I said in forgejo/meta#69 that my migration didn't require additional steps, but I realize I forgot to mention that I already had a bulletproof procedure 😅

Actually, this point is also valid when upgrading from a Forgejo version to another or from a Gitea version to another, because of version numbers in binary names. I guess renaming is an option, but then you loose the simple ability to know which Forgejo version you're running using `ls`. So I use a symlink instead. When updating, I do this : ```bash aria2c <binary> rm <symlink> ln -s <binary> <symlink> ./<binary> ``` Which is why I said in [`forgejo/meta#69`](/forgejo/meta/issues/69) that my migration didn't require additional steps, but I realize I forgot to mention that I already had a bulletproof procedure 😅

crystal commented 2023年02月06日 04:40:56 +01:00

I also added a symlink from forgejo to gitea so I didn't run into any issues either. It's worth noting that my gitea binary was always a symlink to the binary with the latest version number. The only thing that changed in my setup is that forgejo became a symlink to the latest version and gitea became a symlink to forgejo

I also added a symlink from `forgejo` to `gitea` so I didn't run into any issues either. It's worth noting that my `gitea` binary was always a symlink to the binary with the latest version number. The only thing that changed in my setup is that `forgejo` became a symlink to the latest version and `gitea` became a symlink to `forgejo`

KaKi87 commented 2023年02月06日 04:42:04 +01:00

I didn't even bother renaming.

I didn't even bother renaming.

Eragon commented 2023年02月06日 11:25:22 +01:00

Upgrading by using system packages is a common way to do this, most admins will simply take the package from their database repos.

Upgrading by using system packages is a common way to do this, most admins will simply take the package from their database repos.