closes #10
add linting for docs markdown content #13
@ -13,0 +15,4 @@
corepack enable
pnpm install --frozen-lockfile
pnpm run lint:remark
pnpm run lint:prettier
@earl-warren is this the best approach, or would it be better to create a separate action for linting? I guess a separate action would give better at-a-glance insight into what fails from the PR page.
Each run step shows with its name and FWIW I find the separation good enough. What is disturbing is that sometimes the output of a step is found in another. Other than this it is ok.
I initially tried that and then realized it is more difficult to work with. But that's a matter of personal preference, I think. At least with a sequence of run that very much look like a shell script it is easier to figure out what's going on without any Forgejo Action expertise.
@ -553,3 +553,3 @@
- upper - use one or more upper latin characters
- digit - use one or more digits
- spec - use one or more special characters as ``!"#$%&'()*+,-./:;<=>?@[\\]^_`{|}~``
- spec - use one or more special characters as ``!"#$%&'()*+,-./:;<=>?@[\\]^_`{|}~``
What?
Prettier wants to remove the whitespace inside the code tags. It wanted to on the website repo too, it's not to do with the new config. It was just never run on the whole repo before, only on new commits. I thought this seemed like a good time to run it on the whole repo.
Sure. It's just a bit awkward since this is the only change that's not introducing the linter itself. We could make a separate commit with this and merge it first. It should be fine as is, though.
I felt that whilst adding the linter was a good time to lint everything, but if you think it should be a separate commit I'm happy either way.
For what it's worth there are a bunch of other lint changes it might be good to make at some point. In particular, I disabled remark-lint-no-undefined-references because the code is full of unescaped square brackets that aren't meant to be links. Ideally I think it should be re-enabled and they should all be escaped, but that should definitely be a commit of its own because it's a ton of changes.
I'm kind of questioning if it's worth making such a big mess in the docs repo for all the pnpm configuration. An alternative approach would be to have a script that clones the website repo and uses it's pnpm configuration. I think we'll need to have something like that for local previews anyway.
@caesar I think it would be best to squash this, but I'll let you decide how to go about merging it.
I'll squash it, yes.
f3168b65cc
4e059dc7f9
Archived
Archived
Archived
Archived
Archived
Archived
Archived
Archived
Archived
Archived
Archived
No due date set.
No dependencies set.
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?