fix actions conditionals with missing quotes #1023

mahlzahn commented 2025年01月13日 10:17:54 +01:00

This fixes

• again the links.yml, which was not updating issue #583 anymore
• the concerning documentation of actions:

- if: !cancelled()
+ if: '!cancelled()'

(Solution found here)

This fixes - again the links.yml, which was not updating issue #583 anymore - the concerning documentation of actions: ```diff - if: !cancelled() + if: '!cancelled()' ``` (Solution found [here](https://stackoverflow.com/a/58859404))

forgejo-website commented 2025年01月13日 10:19:54 +01:00

Preview ready:
https://forgejo.codeberg.page/@docs_pull_1023/docs/next/user/actions/#conditionals

Preview ready: https://forgejo.codeberg.page/@docs_pull_1023/docs/next/user/actions/#conditionals

mahlzahn commented 2025年01月13日 14:13:01 +01:00

Btw, I put some test workflows here: https://code.forgejo.org/mahlzahn/forgejo-actions-test/src/branch/main/.forgejo/workflows

Maybe, they or parts of them could be integrated into https://code.forgejo.org/forgejo/end-to-end/src/branch/main/actions ?

Btw, I put some test workflows here: https://code.forgejo.org/mahlzahn/forgejo-actions-test/src/branch/main/.forgejo/workflows Maybe, they or parts of them could be integrated into https://code.forgejo.org/forgejo/end-to-end/src/branch/main/actions ?

forgejo-website commented 2025年01月13日 14:42:50 +01:00

The backport to v10.0 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-v10.0 v10.0
# Navigate to the new working tree
cd .worktrees/backport-v10.0
# Create a new branch
git switch --create backport/v10.0/pr-1023
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 900cbfd759cda0efe93f49d0f07e5525152ac8a6
# Push it to GitHub
git push --set-upstream origin backport/v10.0/pr-1023
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-v10.0

Then, create a pull request where the base branch is v10.0 and the compare/head branch is backport/v10.0/pr-1023.

The backport to `v10.0` failed: ``` The process '/usr/bin/git' failed with exit code 1 ``` To backport manually, run these commands in your terminal: ```bash # Fetch latest updates from GitHub git fetch # Create a new working tree git worktree add .worktrees/backport-v10.0 v10.0 # Navigate to the new working tree cd .worktrees/backport-v10.0 # Create a new branch git switch --create backport/v10.0/pr-1023 # Cherry-pick the merged commit of this pull request and resolve the conflicts git cherry-pick -x --mainline 1 900cbfd759cda0efe93f49d0f07e5525152ac8a6 # Push it to GitHub git push --set-upstream origin backport/v10.0/pr-1023 # Go back to the original working tree cd ../.. # Delete the working tree git worktree remove .worktrees/backport-v10.0 ``` Then, create a pull request where the `base` branch is `v10.0` and the `compare`/`head` branch is `backport/v10.0/pr-1023`.

earl-warren commented 2025年01月13日 14:45:32 +01:00

Btw, I put some test workflows here: https://code.forgejo.org/mahlzahn/forgejo-actions-test/src/branch/main/.forgejo/workflows

Maybe, they or parts of them could be integrated into https://code.forgejo.org/forgejo/end-to-end/src/branch/main/actions ?

That sounds like a great idea. There are a few but not enough.

> Btw, I put some test workflows here: https://code.forgejo.org/mahlzahn/forgejo-actions-test/src/branch/main/.forgejo/workflows > > Maybe, they or parts of them could be integrated into https://code.forgejo.org/forgejo/end-to-end/src/branch/main/actions ? That sounds like a great idea. There are [a few](https://code.forgejo.org/forgejo/end-to-end/src/branch/main/actions/example-if-fail) but not enough.

mahlzahn commented 2025年01月13日 20:23:36 +01:00

Finally, it worked. Now, the number of dead links is reduced by one half :)

Finally, it worked. Now, the number of dead links is reduced by one half :)

earl-warren commented 2025年01月14日 11:27:01 +01:00

Yeah!

Yeah!