forgejo-contrib/forgejo-cli
20
408
Fork
You've already forked forgejo-cli
51

fix: detaching when using browse #143

Merged
Cyborus merged 1 commit from :detach into main 2024年11月06日 17:04:18 +01:00
Contributor
Copy link

Fixes: #142

I've changed all open::that with open::that_detached to make sure detaching is enforced.
I don't see a reason to have the browser window attached to the current fj process.

I've also added error handling with eyre (wrap_err) to the function call.

I've tested all the changes successfully with the current main branch.

Fixes: #142 I've changed all `open::that` with `open::that_detached` to make sure detaching is enforced. I don't see a reason to have the browser window attached to the current `fj` process. I've also added error handling with eyre (`wrap_err`) to the function call. I've tested all the changes successfully with the current main branch.
fix: detaching when using browse
All checks were successful
ci/woodpecker/pr/check Pipeline was successful
fb9e3a6635
Member
Copy link

Thanks!

Thanks!
Sign in to join this conversation.
No reviewers
Labels
Clear labels
Kind/Breaking
Breaking change that won't be backward compatible
Kind/Bug
Something is not working
Kind/Design
Discussion about UI/UX design
Kind/Documentation
Documentation changes
Kind/Enhancement
Improve existing functionality
Kind/Feature
New functionality
Kind/Security
This is security issue
Kind/Testing
Issue or pull request related to testing
Kind/Upstream
This is an issue with upstream software (Forgejo) that is probably not our fault
Priority
Critical
 The priority is critical
Priority
High
 The priority is high
Priority
Low
 The priority is low
Priority
Medium
 The priority is medium
Reviewed
Confirmed
 Issue has been confirmed
Reviewed
Duplicate
 This issue or pull request already exists
Reviewed
Invalid
 Invalid issue
Reviewed
Won't Fix
 This issue won't be fixed
Status
Abandoned
 Somebody has started to work on this but abandoned work
Status
Blocked
 Something is blocking this issue or pull request
Status
Need More Info
 Feedback is required to reproduce issue or to continue work
Suspicious
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
forgejo-contrib/forgejo-cli!143
Reference in a new issue
forgejo-contrib/forgejo-cli
No description provided.
Delete branch ":detach"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?