In #834, it was decided to move the version string to the bottom-left corner, and a new PR was opened to address it.
In #834, it was decided to move the version string to the bottom-left corner, and a new PR was opened to address it.
fairyglade/ly
Move version string to bottom-left corner #846
Merged
AnErrupTion
merged 2 commits from 2025年10月11日 09:24:16 +02:00
nyraa/ly:chore/version-to-bottom into master
nyraa
commented 2025年10月10日 13:28:59 +02:00
AnErrupTion
requested changes 2025年10月11日 08:52:10 +02:00
Dismissed
AnErrupTion
left a comment
As it was said in #845 (comment), because the version string is being moved to the bottom-left corner, the version string check for the battery status must be removed (see PR #845 to know where it is).
Otherwise, the change looks pretty fine!
As it was said in https://codeberg.org/fairyglade/ly/pulls/845#issuecomment-7662007, because the version string is being moved to the bottom-left corner, the version string check for the battery status must be removed (see PR #845 to know where it is).
Otherwise, the change looks pretty fine!
nyraa
force-pushed chore/version-to-bottom from 2025年10月11日 09:15:11 +02:00
Compare
1f5180b7b7
to 75c7bf1199
nyraa
commented 2025年10月11日 09:19:18 +02:00
I've rebased my changes on the latest master and removed the version string check for the battery label.
I've rebased my changes on the latest master and removed the version string check for the battery label.
AnErrupTion
approved these changes 2025年10月11日 09:24:05 +02:00
AnErrupTion
left a comment
Alright, LGTM now! Thanks for your contribution!
Alright, LGTM now! Thanks for your contribution!
AnErrupTion
merged commit cb4f1952cd into master 2025年10月11日 09:24:16 +02:00
AnErrupTion
referenced this pull request from a commit 2025年10月11日 09:24:17 +02:00
Sign in to join this conversation.
No reviewers
Labels
Clear labels
bug
This issue or pull request discusses a bug
clue
This issue or pull request contains valuable information
docs
This issue or pull request discusses documentation
feature
This issue or pull request discusses a feature
ko
This issue is not an issue
needs review
This issue or pull request must be confirmed/reviewed
ok
This issue or pull request was confirmed/reviewed
upstream/kmscon
This issue or pull request deals with an upstream issue about KMSCON
upstream/zig
This issue or pull request deals with an upstream issue about Zig
wip
This issue or pull request is a draft
wont
This issue or pull request won't be fixed/merged
No labels
bug
clue
docs
feature
ko
needs review
ok
upstream/kmscon
upstream/zig
wip
wont
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".
No due date set.
Dependencies
No dependencies set.
Reference
fairyglade/ly!846
Loading...
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "nyraa/ly:chore/version-to-bottom"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?