fairplayer/fairplayer
7
10
Fork
You've already forked fairplayer
2

header-template-app-agnostic #525

Open
MaciAc wants to merge 2 commits from header-template-app-agnostic into hub-redesign-v2-refactor-header
pull from: header-template-app-agnostic
merge into: fairplayer:hub-redesign-v2-refactor-header
fairplayer:main
fairplayer:analytics-published
fairplayer:soft-delete-node
fairplayer:scan-song-contributors
fairplayer:cms-wagtail
fairplayer:add-footer-component
fairplayer:hub-redesign-v2-refactor-header
fairplayer:light-mode
fairplayer:hub-redesign-v2-node-page
fairplayer:reindex-job-schedule
fairplayer:hub-redesign-v2
fairplayer:site-customization-model-extension
fairplayer:initial-site-customisation-model
fairplayer:i18nc-on-setup
fairplayer:latinize
fairplayer:retitle
fairplayer:hub-redesign
fairplayer:service-worker
fairplayer:z-index-revisited
fairplayer:timeline-story
fairplayer:install-pwa-prompt
fairplayer:feature/signup-revamp
fairplayer:feature/login-revamp
fairplayer:improve-onboarding
fairplayer:player-logos-styles-various

Following comments on fairplayer/fairplayer!518 I am proposing a deeper refactor where we are able to define the nav-content and other header related variables depending on the app.

Following comments on fairplayer/fairplayer!518 I am proposing a deeper refactor where we are able to define the nav-content and other header related variables depending on the app.
specific header conf for home so we can remove top paddings
All checks were successful
ci/woodpecker/pr/code-quality Pipeline was successful
d45af01a33
@ -49,0 +49,4 @@
@register.inclusion_tag("components/header.html", takes_context=True)
def render_header(context, app_name=None):
Owner
Copy link

Typically the tag name represents the object that will be rendered on the page. I suggest we call this just header.

Typically the tag name represents the object that will be rendered on the page. I suggest we call this just `header`.
Owner
Copy link

Also, can we put this template tag in a separate module? The rest of this module was intended as a reusable general-purpose way to create "components" in HTML. This to me deserves a new header.py specific tag.

Also, can we put this template tag in a separate module? The rest of this module was intended as a reusable general-purpose way to create "components" in HTML. This to me deserves a new `header.py` specific tag.
All checks were successful
ci/woodpecker/pr/code-quality Pipeline was successful
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin header-template-app-agnostic:header-template-app-agnostic
git switch header-template-app-agnostic

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch hub-redesign-v2-refactor-header
git merge --no-ff header-template-app-agnostic
git switch header-template-app-agnostic
git rebase hub-redesign-v2-refactor-header
git switch hub-redesign-v2-refactor-header
git merge --ff-only header-template-app-agnostic
git switch header-template-app-agnostic
git rebase hub-redesign-v2-refactor-header
git switch hub-redesign-v2-refactor-header
git merge --no-ff header-template-app-agnostic
git switch hub-redesign-v2-refactor-header
git merge --squash header-template-app-agnostic
git switch hub-redesign-v2-refactor-header
git merge --ff-only header-template-app-agnostic
git switch hub-redesign-v2-refactor-header
git merge header-template-app-agnostic
git push origin hub-redesign-v2-refactor-header
Sign in to join this conversation.
No reviewers
Labels
Clear labels
alert
Alerts spotted by our monitoring that may need to be addressed
content
Landing pages, text, translations
decommission
Use this to flag PRs that include functionality that has been removed, in case one day we want to get some of it back.
design
devx
Developer experience: tech docs, local dev, testing, CI, deployment, delivery or general codebase maintenance
good first issue
good for newcomers
i18n
Internationalisation, translations
kind
bug
kind
feature
module/catalog
The now deprecated catalog module
module/hub
The hub module (also known as indexer) and artist backend
module/player
The music player / listener-facing application
module/search
Search functionalities (which can be available also outside the player experience)
ops
Operations - management of the fairplayer.band instance, infrastructure...
security
Everything security: patches, dependency upgrades, remediations...
source
canimus
 Support for the canimus protocol and catalogs that use it
source
faircamp
 Support for Faircamp sites as music catalogs
source
funkwhale
source
mirlo
 Support for Mirlo instances as music catalogs
ux
workaround
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
fairplayer/fairplayer!525
Reference in a new issue
fairplayer/fairplayer
No description provided.
Delete branch "header-template-app-agnostic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?