19
206
Fork
You've already forked evi
15

Apply @zerodogg's patch to fix #122 #151

Open
amything wants to merge 1 commit from amything/evi:fix-122 into master
pull from: amything/evi:fix-122
merge into: evi-editor:master
evi-editor:master
evi-editor:add_v10_txt
evi-editor:fix_test_version
evi-editor:add_evi_feature_for_has
evi-editor:78_remove_netbeans
evi-editor:lia
evi-editor:rename_vimtutor
evi-editor:branding_updates
evi-editor:fix_undo_tests
evi-editor:various_replacements_and_fix
evi-editor:more_test_fix
evi-editor:fixing_tests
No description provided.
Author
Owner
Copy link

Also wrote small details on the wiki for Debian.

Also wrote small details on the wiki for Debian.

Wouldn't this break stuff on older releases? Also, has it been thoroughly tested to not break any functionality?

Wouldn't this break stuff on older releases? Also, has it been thoroughly tested to not break any functionality?
Author
Owner
Copy link

@Reiddragon wrote in #151 (comment):

Wouldn't this break stuff on older releases? Also, has it been thoroughly tested to not break any functionality?

how exactly?

@Reiddragon wrote in https://codeberg.org/evi-editor/evi/pulls/151#issuecomment-17857721: > Wouldn't this break stuff on older releases? Also, has it been thoroughly tested to not break any functionality? how exactly?

@amything wrote in #151 (comment):

@Reiddragon wrote in #151 (comment):

Wouldn't this break stuff on older releases? Also, has it been thoroughly tested to not break any functionality?

how exactly?

you're outright removing code. I don't know what exactly it does but if something on older Python releases relies on that code it could cause issues.

@amything wrote in https://codeberg.org/evi-editor/evi/pulls/151#issuecomment-17870753: > @Reiddragon wrote in #151 (comment): > > > Wouldn't this break stuff on older releases? Also, has it been thoroughly tested to not break any functionality? > > how exactly? you're outright removing code. I don't know what exactly it does but if something on older Python releases relies on that code it could cause issues.
Author
Owner
Copy link

well, i can test.

well, i can test.
Author
Owner
Copy link

oki, it doesnt seem to break older python stuff after my testing

oki, it doesnt seem to break older python stuff after my testing
This pull request doesn't have enough approvals yet. 1 of 2 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix-122:amything-fix-122
git switch amything-fix-122
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
evi-editor/evi!151
Reference in a new issue
evi-editor/evi
No description provided.
Delete branch "amything/evi:fix-122"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?