Erez Shomron eshom · he/him
  • Joined on 2024年08月09日
eshom commented on issue ziglang/zig#31960 2026年05月20日 12:09:35 +02:00
Crash when the build system creates options.zig with a atomic file

I've updated ziglang/zig#31542's title so it includes all "less common" filesystems, i.e. not covered by CI.

eshom commented on issue ziglang/zig#31960 2026年05月06日 23:39:35 +02:00
Crash when the build system creates options.zig with a atomic file

Duplicate of ziglang/zig#31542

eshom commented on pull request ziglang/zig#31547 2026年03月21日 12:13:32 +01:00
[WIP] Use the rename shuffle as a fallback if renaming output returns AccessDenied.

If this logic is accepted, then it should be implemented in Io.Uring too and at the very least tested manually, because at the time of writing this, unit tests don't cover Io.Evented...

eshom commented on pull request ziglang/zig#31547 2026年03月21日 12:13:29 +01:00
[WIP] Use the rename shuffle as a fallback if renaming output returns AccessDenied.

If openat reveals the file exists, I think it's better to return error.PathAlreadyExists to simulate what happens with NOREPLACE instead of panic.

eshom commented on pull request ziglang/zig#31547 2026年03月21日 12:13:27 +01:00
[WIP] Use the rename shuffle as a fallback if renaming output returns AccessDenied.

Wouldn't it be better to just call Threaded.renameat here instead of complicating control flow by mutating the flags?

eshom commented on pull request ziglang/zig#31547 2026年03月21日 12:13:24 +01:00
[WIP] Use the rename shuffle as a fallback if renaming output returns AccessDenied.

This is always true, so the branch is unnecessary.

eshom commented on issue ziglang/zig#31231 2026年03月21日 11:13:55 +01:00
Calling createFileAtomic throws unexpected errno: 95

I've updated this follow up issue here: ziglang/zig#31542

eshom deleted branch tmpfile-not-supported from eshom/zig 2026年03月21日 01:02:52 +01:00
eshom commented on pull request ziglang/zig#31543 2026年03月20日 09:12:03 +01:00
linux: fix handling of O_TMPFILE flag on filesystems that do not support it

Thanks, though I prefer to keep it as OpenError. I think it's clear enough from the namespace, it mirrors std.Io.Threaded, and it's nicer for when you grep. Otherwise, OpenAtError would be...

eshom pushed to tmpfile-not-supported at eshom/zig 2026年03月20日 09:01:04 +01:00
8caf430b0f std.Io.Uring: handle UnsupportedOperation for O_TMPFILE case
9f62389a17 std.Io.Threaded: syscall with O_TMPFILE flag can return OPNOTSUPP
06b85a4fd0 CLI: use zon format for clang options
982f26bcdd netReceiveOneWindows: fix typo
4acecad933 bootstrap.c: work around the gcc sra miscomp using preprocessor checks rather than CLI arg (#31589)
Compare 14 commits »
eshom commented on pull request ziglang/zig#31543 2026年03月18日 21:58:03 +01:00
linux: fix handling of O_TMPFILE flag on filesystems that do not support it

Rebased now and cleaned up the commit history, which I should have done in the first place. Again, thank you both.

eshom pushed to tmpfile-not-supported at eshom/zig 2026年03月18日 21:54:41 +01:00
5921d48565 std.Io.Uring: handle UnsupportedOperation for O_TMPFILE case
f67369c4ea std.Io.Threaded: syscall with O_TMPFILE flag can return OPNOTSUPP
485b996b61 Make benchmarking use std.Io.Clock.awake for timing (#31553)
ce1f7136ae Merge pull request 'cbe: fix switch statements on large types' (#31557) from justusk/zig:cbe-switch-128 into master
c10089d060 test: enable 'switch arbitrary int size' behavior test for cbe
Compare 8 commits »
eshom pushed to tmpfile-not-supported at eshom/zig 2026年03月18日 21:51:01 +01:00
520cf4969b std.Io.Uring: handle UnsupportedOperation for O_TMPFILE case
5d44d4a1ee std.Io.Threaded: syscall with O_TMPFILE flag can return OPNOTSUPP
820308b3d4 Merge pull request 'libzigc: Implement tanhf, tanh, modfl, modff, modf, acoshf, asin' (#31536) from mihael/zig:libzigc/more-math-functions into master
f8997aca8f Merge pull request 'llvm: some random fixes' (#31552) from llvm-fixes into master
85837de476 llvm: solve a bunch of alignment bugs
Compare 28 commits »
eshom commented on pull request ziglang/zig#31543 2026年03月18日 00:18:06 +01:00
linux: fix handling of O_TMPFILE flag on filesystems that do not support it

Thanks for the tip!

eshom commented on pull request ziglang/zig#31543 2026年03月17日 21:26:08 +01:00
linux: fix handling of O_TMPFILE flag on filesystems that do not support it

While it's not necessary for Io.Threaded implementation on its own, and that's how this PR started, I've added this error code to File.OpenError because of the Io.Uring implementation.

eshom commented on pull request ziglang/zig#31543 2026年03月16日 23:46:21 +01:00
linux: fix handling of O_TMPFILE flag on filesystems that do not support it

Thanks. Updated both std.Io.Threaded and std.Io.Uring implementations.

eshom pushed to tmpfile-not-supported at eshom/zig 2026年03月16日 23:43:36 +01:00
84c34d9210 remove operation unsupported error from CreateFileAtomicError
cfea848ca2 fix std tests compilation errors
b40c8e1b35 std.Io.Uring: handle UnsupportedOperation for O_TMPFILE case
4441a7ed80 std.Io.Threaded: syscall with O_TMPFILE flag can return OPNOTSUPP
2d237da50b Merge pull request 'std.math.pow: fix wrong answer for large even exponents' (#31537) from TemariVirus/zig:master into master
Compare 10 commits »
eshom created pull request ziglang/zig#31543 2026年03月16日 22:12:08 +01:00
linux: fix handling of O_TMPFILE flag on filesystems that do not support it
eshom pushed to tmpfile-not-supported at eshom/zig 2026年03月16日 21:36:23 +01:00
f4aee6fd6f fix std tests compilation errors
552b6e5cd7 std.Io.Uring: handle UnsupportedOperation for O_TMPFILE case
e89faa0f20 std.Io.Threaded: syscall with O_TMPFILE flag can return OPNOTSUPP
125c1f3dd9 bit_set: specify the backing integer for IntegerBitSet, allowing it to be used in extern structs
abd099e97f Merge pull request 'compiler: fix missing "local variable is never mutated" error' (#31534) from variable-not-mutated into master
Compare 14 commits »
eshom opened issue ziglang/zig#31542 2026年03月16日 20:50:48 +01:00
std.fs test failures on NFS on linux