7
123
Fork
You've already forked soju
36

downstream: fast forward history for new channels on connect #8

Open
chamlis wants to merge 1 commit from chamlis/soju:fast-forward-new-clients into master
pull from: chamlis/soju:fast-forward-new-clients
merge into: emersion:master
emersion:master
emersion:v0.10
emersion:webpush-state
emersion:feature-introspection-username
emersion:v0.6
emersion:v0.2
Contributor
Copy link

If a client connects to see a new channel but disconnects before a message is sent there, it should still receive any logs from that channel when it next connects.

The case of a client joining a new channel to which no messages are then sent works because the JOIN is a message with an ID.

If a client connects to see a new channel but disconnects before a message is sent there, it should still receive any logs from that channel when it next connects. The case of a client joining a new channel to which no messages are then sent works because the JOIN is a message with an ID.

Hm, it seems like this is similar to https://lists.sr.ht/~emersion/soju-dev/patches/27263

(I also wrote a test for this at some point: https://lists.sr.ht/~emersion/soju-dev/patches/28130)

Hm, it seems like this is similar to https://lists.sr.ht/~emersion/soju-dev/patches/27263 (I also wrote a test for this at some point: https://lists.sr.ht/~emersion/soju-dev/patches/28130)
Author
Contributor
Copy link

Ahh yes, it seems I was a few years late. I'm happy to close this in favour of the preexisting work on this, or bring that test into this branch.

Ahh yes, it seems I was a few years late. I'm happy to close this in favour of the preexisting work on this, or bring that test into this branch.
chamlis force-pushed fast-forward-new-clients from d061b2248e
All checks were successful
builds.sr.ht Job completed
to 707cab32fc
Some checks reported errors
builds.sr.ht Job failed
2024年12月31日 23:39:52 +01:00 Compare
Author
Contributor
Copy link

At first blush the CI failure looks like a race condition in the testing infrastructure. If I'm mistaken, please let me know.

At first blush the CI failure looks like a race condition in the testing infrastructure. If I'm mistaken, please let me know.
Some checks reported errors
builds.sr.ht Job failed
Required
Details
Some required checks were not successful.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fast-forward-new-clients:chamlis-fast-forward-new-clients
git switch chamlis-fast-forward-new-clients
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
emersion/soju!8
Reference in a new issue
emersion/soju
No description provided.
Delete branch "chamlis/soju:fast-forward-new-clients"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?