5
138
Fork
You've already forked goguma
18

WIP: Display bouncer network errors in banners #77

Draft
delthas wants to merge 1 commit from delthas/goguma:feature-error-banner into master
pull from: delthas/goguma:feature-error-banner
merge into: emersion:master
emersion:master
emersion:irc-socket
emersion:webcrypto-0.6.1
emersion:high-level-message
emersion:blocked
emersion:web
emersion:scrollable-positioned-list
emersion:l10n
emersion:ci-jvm-size
emersion:extended-isupport
emersion:drop-flutter-background
emersion:dup-main
emersion:android-decl-plugins
Collaborator
Copy link

Intending to replace BouncerServ notices.

Intending to replace BouncerServ notices. ![](https://ircf.delthas.fr/uploads/delthas/a02392b6-Screenshot%20From%202025-12-10%2016-39-50.png)
Display bouncer network errors in banners
Some checks reported errors
builds.sr.ht/android Job failed
42284cba30 
Intending to replace BouncerServ notices.
Author
Collaborator
Copy link
  • I don't think changes to a bouncer network > attrs > error are properly listened up to the NetworkListModel, so the banner is not updated when an error occurs/changes
  • Using setState to trigger a rebuild on changing lastDismissedError does not look great
  • Maybe the notices should be shown with a dark background like NOTICEs?
- I don't think changes to a bouncer network > attrs > error are properly listened up to the NetworkListModel, so the banner is not updated when an error occurs/changes - Using setState to trigger a rebuild on changing lastDismissedError does not look great - Maybe the notices should be shown with a dark background like NOTICEs?
Some checks reported errors
builds.sr.ht/android Job failed
This pull request has changes conflicting with the target branch.
  • lib/database.dart
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u feature-error-banner:delthas-feature-error-banner
git switch delthas-feature-error-banner

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch master
git merge --no-ff delthas-feature-error-banner
git switch delthas-feature-error-banner
git rebase master
git switch master
git merge --ff-only delthas-feature-error-banner
git switch delthas-feature-error-banner
git rebase master
git switch master
git merge --no-ff delthas-feature-error-banner
git switch master
git merge --squash delthas-feature-error-banner
git switch master
git merge --ff-only delthas-feature-error-banner
git switch master
git merge delthas-feature-error-banner
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
emersion/goguma!77
Reference in a new issue
emersion/goguma
No description provided.
Delete branch "delthas/goguma:feature-error-banner"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?