0
0
Fork
You've already forked comaps
0
forked from comaps/comaps

carplay-0708 #23

Open
eisa01 wants to merge 22 commits from carplay-0708 into modes-ui
pull from: carplay-0708
merge into: eisa01:modes-ui
eisa01:main
eisa01:eisa01/carplay-road-shields
eisa01:multi-surface-map-rendering
eisa01:carplay-dashboard-support
eisa01:modes-ui
eisa01:forgejo-macos-runner
eisa01:create-venv
eisa01:carplay-0706
eisa01:carplay-0704-findings
eisa01:fable-review
eisa01:testflight/2026.06.30
eisa01:carplay-dashboard
eisa01:carplay-om-code-review
eisa01:carplay-code-review-jun28
eisa01:carplay-dashboard-mvp2
eisa01:car-follow-on-reacquire
eisa01:carplay-location-keepalive
eisa01:testflight/2026.06.20
eisa01:carplay-roundabout-exit-number
eisa01:carplay-destination
eisa01:carplay-dashboard-mvp
eisa01:name-cherry-picking
eisa01:om-pr-11243-2
eisa01:icu-cjk-fix
eisa01:simple-cjk-fix
eisa01:fix-crash-search
eisa01:scene-support
eisa01:om-carplay-button
eisa01:om-pr-10545
eisa01:submodule-main-branch
eisa01:improve-unit-testing-docs

Description

WIP

Submitter checklist

  • All code changes and commit messages conform to the appropriate style guide
  • I have signed off all my commits with the Developers Certificate of Origin
  • All communication (commit messages, pull request messages, documentation, and code comments) is human written and not authored by AI
  • I take full responsibility of all changes submitted in this pull request
### Description WIP ### Submitter checklist - [x] All code changes and commit messages conform to the appropriate [style guide](https://codeberg.org/comaps/comaps/src/branch/main/docs/CONTRIBUTING.md#code-contributions) - [x] I have signed off all my commits with the [Developers Certificate of Origin](https://codeberg.org/comaps/Governance/src/branch/main/DCO.md) - [x] All communication (commit messages, pull request messages, documentation, and code comments) is human written and not authored by AI - [x] I take full responsibility of all changes submitted in this pull request
Generated with the help of Claude Opus 4.8
Generated with the help of Claude Opus 4.8 and Fable 5
Signed-off-by: eisa01 <eisa01@gmail.com>
Otherwise too zoomed in for the car speed
Generated with the help of Claude Opus 4.8
Signed-off-by: eisa01 <eisa01@gmail.com>
Solves crashes observed in the simulator while testing CarPlay
It was possible get a NaN matrix that lead to tripping the
m2::Rect min<=max assert in rect2d.hpp
Generated with help of Opus 4.8
Signed-off-by: eisa01 <eisa01@gmail.com>
Rapid switching during CarPlay simulator testing tripped an assert here with invalid m2::RectD
Add guards to not call degenerate viewports
Generated with the help of Claude Opus 4.8
Signed-off-by: eisa01 <eisa01@gmail.com>
This pull request has changes conflicting with the target branch.
  • iphone/Maps/Classes/MapsAppDelegate.mm
  • libs/map/framework.cpp
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin carplay-0708:carplay-0708
git switch carplay-0708

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch modes-ui
git merge --no-ff carplay-0708
git switch carplay-0708
git rebase modes-ui
git switch modes-ui
git merge --ff-only carplay-0708
git switch carplay-0708
git rebase modes-ui
git switch modes-ui
git merge --no-ff carplay-0708
git switch modes-ui
git merge --squash carplay-0708
git switch modes-ui
git merge --ff-only carplay-0708
git switch modes-ui
git merge carplay-0708
git push origin modes-ui
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eisa01/comaps!23
Reference in a new issue
eisa01/comaps
No description provided.
Delete branch "carplay-0708"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?