eicas/website
4
1
Fork
You've already forked website
1

Add image with link but no text option #72

Open
codehippo wants to merge 1 commit from image-link--no-text into main
pull from: image-link--no-text
merge into: eicas:main
eicas:main
eicas:upgrade-Laravel-9-to-10
eicas:update-laravel
eicas:nix-shell
eicas:search
eicas:update-security-txt
eicas:mobile-select-appropriate-resolution-image
eicas:update-readme
eicas:adjust-target-link-gallery
eicas:add-security-txt
eicas:desktop-menu-top
eicas:update-piwik-matomo-link
eicas:bugfix-null-error-in-payment
eicas:fix-mollie-test-override
eicas:fix-visible-square-for-empty-gallery-titles
eicas:noopener
eicas:fix-non-working-email-verification
eicas:imageset-image-custom-title-without-link
eicas:external-links-new-tab
eicas:desktop-galerij-titels
eicas:fix-datalimit-500
eicas:login-for-friends-admin-side
eicas:remove-twitter
eicas:new-tagline
eicas:add-EoM-estimate
eicas:fix-no-template-top-padding
eicas:usage-mail-cron
eicas:add-no-template-padding
eicas:usage-mail
eicas:logo-background-galleries
eicas:redirect-commons-links
eicas:logo-padding-bg
eicas:logo-add-transparency
eicas:cache-busting
eicas:nieuw-logo
eicas:format-package-json
eicas:php8
eicas:add-mit-license
eicas:rel=me
eicas:social-image-selection-and-metadata
eicas:fix-shop-image-picker
eicas:delete-images
eicas:keep-background-when-resizing
eicas:link-to-images
eicas:output-content-length-for-static-resources
eicas:fix-image-picker-alt-attribute
eicas:orientate-uploaded-images
eicas:add-mit-license-4
eicas:fix-edit-shop-items
eicas:embed-only-first-images
eicas:canonical
eicas:deterministic-image-popup
eicas:use-picture-tag
eicas:fix-no-gallery-mobile
eicas:more-deterministic-menuitem-ids
eicas:document-backup-restore
eicas:add-main-landmark
eicas:bandcamp
eicas:datalimit
eicas:pages
eicas:better-description-of-db-migration
eicas:restore-title-to-bidbook-template
eicas:bust-social-cache
eicas:associate-labels-with-fields
eicas:add-placeholder-alt-tag
eicas:create-page-with-description
eicas:og-description
eicas:description
eicas:black-links
eicas:add-bidbook-template
eicas:ignore-docker-compose
eicas:social-previews
eicas:add-twitter
eicas:avoid-transparency-in-apple-touch-icon
eicas:opengraph

Feature implementing images without text, but with a link.

Feature implementing images without text, but with a link.
raboof left a comment
Owner
Copy link

Looks like a good start, a few comments

Looks like a good start, a few comments
@ -27,3 +27,3 @@
return [
'href' => 'nullable|string',
'alt' => 'nullable|required_with:href|string',
'alt' => 'nullable|string', // required_with:href|
Owner
Copy link

👍- I think it's fine to delete the old thing entirely instead of commenting it out - we can always find it in the git history if needed.

👍- I think it's fine to delete the old thing entirely instead of commenting it out - we can always find it in the git history if needed.
@ -52,3 +47,1 @@
'tagName' => 'div',
'className' => 'image-preview-parent',
];
if (! $image->pivot->href) {
Owner
Copy link

so we have 3 cases: 'link and text', 'no link and text', and 'link and no text'. I think it would be more readable to have those at the same 'level': so instead of "if .. else { if .. else .. }" write it as "if .. elseif .. else .."

so we have 3 cases: 'link and text', 'no link and text', and 'link and no text'. I think it would be more readable to have those at the same 'level': so instead of "if .. else { if .. else .. }" write it as "if .. elseif .. else .."
@ -55,0 +54,4 @@
'className' => 'image-preview-parent',
];
} else {
// External link to be opened in new browser tab
Owner
Copy link

This is not necessarily true here, right? This might be a good opportunity to move the logic to determine whether the link is external or not to a re-usable function.

This is not necessarily true here, right? This might be a good opportunity to move the logic to determine whether the link is external or not to a re-usable function.
This pull request doesn't have enough approvals yet. 0 of 1 approvals granted.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u origin image-link--no-text:image-link--no-text
git switch image-link--no-text
Sign in to join this conversation.
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eicas/website!72
Reference in a new issue
eicas/website
No description provided.
Delete branch "image-link--no-text"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?