10
9
Fork
You've already forked linux-app
14

Refactor selections #491

Merged
jwijenbergh merged 1 commit from refactor-selections into master 2022年06月16日 17:53:22 +02:00
jwijenbergh commented 2022年06月13日 17:29:44 +02:00 (Migrated from github.com)
Copy link

Fixes part of #465 (profile gets selected unwillingly)

This has a bunch of benefits to the way we did it before. In short it replaces the selection signals for treeviews into activated signals which is the proper way to do things. For this, we need to set up the needed signals and change the activated trigger from double click to single click. Additionally, it also sets selection hover so that the user can easily see which entry would be activated on a click!

So in short, we get the following improvements:

  • We can now see the selection before it gets activated more reliably
  • No more buggy selections because the user actually has to click on it instead of clicking anywhere
  • Way simpler code

Draft because I want at least a confirmation from 1 other maintainer that this works well, and I need to test it on some vms.

Fixes part of #465 (profile gets selected unwillingly) This has a bunch of benefits to the way we did it before. In short it replaces the *selection* signals for treeviews into *activated* signals which is the proper way to do things. For this, we need to set up the needed signals and change the activated trigger from double click to single click. Additionally, it also sets selection hover so that the user can easily see which entry would be activated on a click! So in short, we get the following improvements: - We can now see the selection before it gets activated more reliably - No more buggy selections because the user actually has to click on it instead of clicking *anywhere* - Way simpler code Draft because I want at least a confirmation from 1 other maintainer that this works well, and I need to test it on some vms.
jwijenbergh commented 2022年06月16日 13:57:03 +02:00 (Migrated from github.com)
Copy link

Works fine

Works fine
gijzelaerr commented 2022年06月16日 17:53:18 +02:00 (Migrated from github.com)
Copy link

i think this might also solve a bug that I had in 1.x. great detective work, thanks.

i think this might also solve a bug that I had in 1.x. great detective work, thanks.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eduVPN/linux-app!491
Reference in a new issue
eduVPN/linux-app
No description provided.
Delete branch "refactor-selections"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?