7
3
Fork
You've already forked android
4

Adds a signing script #46

Open
douwe3998 wants to merge 1 commit from douwe3998/sign:sign_branch into master
pull from: douwe3998/sign:sign_branch
merge into: eduVPN:master
eduVPN:master
eduVPN:feature/bugfixes
eduVPN:feature/tile_service
eduVPN:feature/mte_crash
eduVPN:feature/update-ics
eduVPN:feature/proxyguard_via_wireguard
eduVPN:feature/include_list
eduVPN:feature/threading_fix
First-time contributor
Copy link

Added a sign.sh file that signs an unsigned .apk en .aab file

Added a sign.sh file that signs an unsigned .apk en .aab file

shellcheck gave a warning

In sign.sh line 6:
BUILD_TOOLS_VERSION=$(ls "${SKD_DIR}"/build-tools/ | sort -r | head -1)
 ^--------------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames.
For more information:
 https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ...
shellcheck gave a warning ``` In sign.sh line 6: BUILD_TOOLS_VERSION=$(ls "${SKD_DIR}"/build-tools/ | sort -r | head -1) ^--------------------------^ SC2012 (info): Use find instead of ls to better handle non-alphanumeric filenames. For more information: https://www.shellcheck.net/wiki/SC2012 -- Use find instead of ls to better ... ```
@ -0,0 +1,28 @@
#!/bin/bash

add set -e here such that each step of the script exits when it fails

add `set -e` here such that each step of the script exits when it fails

then you can remove the || exit on each line later on

then you can remove the `|| exit` on each line later on
@ -0,0 +1,28 @@
#!/bin/bash

replace with /bin/sh, but then you need to do the replacement on line 9 with something else. If you must stick to bash, prefer to use /usr/bin/env bash as not each system has bash at /bin/bash

replace with `/bin/sh`, but then you need to do the replacement on line 9 with something else. If you must stick to bash, prefer to use `/usr/bin/env bash` as not each system has bash at `/bin/bash`
@ -0,0 +25,4 @@
cp "${UNSIGNED_AAB}" "${OUTPUT_DIR}/${SIGNED_AAB}" || exit
mv "${UNSIGNED_APK}.idsig" "${OUTPUT_DIR}"

remove empty line

remove empty line

looks pretty good! Some small comments

looks pretty good! Some small comments
@ -0,0 +13,4 @@
OUTPUT_DIR=signed
if [ ! -d "${OUTPUT_DIR}" ]; then

you can also do mkdir -p without the if.

you can also do `mkdir -p` without the if.
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u sign_branch:douwe3998-sign_branch
git switch douwe3998-sign_branch
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
eduVPN/android!46
Reference in a new issue
eduVPN/android
No description provided.
Delete branch "douwe3998/sign:sign_branch"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?