35
142
Fork
You've already forked dwl-patches
97

edit bar.patch #78

Closed
rxmmah wants to merge 8 commits from (deleted):main into main
pull from: (deleted):main
merge into: dwl:main
dwl:main
dwl:legacy
First-time contributor
Copy link

i just removed the widow title from the bar to give users a choice.

thank your for your work

i just removed the widow title from the bar to give users a choice. **thank your for your work**
Member
Copy link

You made a variant of the patch instead of making a patch to remove it from the original patch.

Please read the dwl-patches guidelines, and make a patch called 'notitle' which is supposed to apply on top of the bar patch. If you'd like, you can request to me to make the split status patch.

You made a variant of the patch instead of making a patch to remove it from the original patch. Please read the dwl-patches guidelines, and make a patch called 'notitle' which is supposed to apply on top of the bar patch. If you'd like, you can request to me to make the split status patch.
Member
Copy link

Please make a patch (which applies on bar), not a variant of the entire patch under your name, this makes maintainability of the patch difficult and hard to keep up with updates of the original patch.

Please make a patch (which applies on bar), not a variant of the entire patch under your name, this makes maintainability of the patch difficult and hard to keep up with updates of the original patch.
Author
First-time contributor
Copy link

please see the edit i made.

please see the edit i made.

Hello,

I think it would make more sense to keep bar in the name, so its obvious the patch is for bar, something like barnotitle.

Hello, I think it would make more sense to keep bar in the name, so its obvious the patch is for bar, something like barnotitle.
Member
Copy link

so its obvious the patch is for bar, something like barnotitle

Why? There is already a patch for bar without bar in the name called hide_vacant_tags. I agree with your idea of categorizing patches, but it is redundant to add patch in the name when it can be inferred that the patch is for the bar (eg. notitle or hide_vacant_tags)

> so its obvious the patch is for bar, something like barnotitle Why? There is already a patch for bar without bar in the name called hide_vacant_tags. I agree with your idea of categorizing patches, but it is redundant to add patch in the name when it can be inferred that the patch is for the bar (eg. `notitle` or `hide_vacant_tags`)

It's not obvious to me tbh. Also in the future if there were multiple bars available, this would easily distinguish between what dependent patch is for which one

It's not obvious to me tbh. Also in the future if there were multiple bars available, this would easily distinguish between what dependent patch is for which one

@rxmmah Please rebase your patch and squash to one commit.

@rxmmah Please rebase your patch and squash to one commit.

@i0rxc (formerly @rxmmah <- for consistency when reading this thread): Are you still interested in completing/maintaining this patch? If so, please properly rebase and squash commits.

@i0rxc (formerly @rxmmah <- for consistency when reading this thread): Are you still interested in completing/maintaining this patch? If so, please properly rebase and squash commits.
rxmmah closed this pull request 2025年01月15日 00:02:27 +01:00

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
4 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dwl/dwl-patches!78
Reference in a new issue
dwl/dwl-patches
No description provided.
Delete branch "(deleted):main"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?