13
295
Fork
You've already forked yambar
74

Differentiate "Not Charging" and "Discharging" in state tag of battery module. #58

Manually merged
dnkl merged 2 commits from mz/yambar:master into master 2021年06月15日 05:20:07 +02:00
Contributor
Copy link

Some batteries support charge thresholds and when the upper limit is set to a number less than 100 percent and it reaches that limit and it is connected to the charger the battery state will be "Not charging".
It doesn't charge anymore despite it's not full.

Some batteries support charge thresholds and when the upper limit is set to a number less than 100 percent and it reaches that limit and it is connected to the charger the battery state will be "Not charging". It doesn't charge anymore despite it's not full.
Some batteries support charge thresholds and when the upper limit is set to a number less than 100 percent and it reaches that limit and it is connected to the charger the battery state will be "Not charging".
It doesn't charge anymore despite it's not full.
dnkl left a comment
Copy link

Heh, I literally just sat down and was about to write up a patch just like this one :D

Looks good to me.

Would you mind updating the documentation (doc/yambar-modules-battery.5.scd), and adding an entry to CHANGELOG.md (and feel free to add yourself to the contributors list while you're in that file!)

Heh, I literally just sat down and was about to write up a patch just like this one :D Looks good to me. Would you mind updating the documentation (`doc/yambar-modules-battery.5.scd`), and adding an entry to `CHANGELOG.md` (and feel free to add yourself to the _contributors_ list while you're in that file!)
Author
Contributor
Copy link

I just finished editing the example config file. :D
I will edit the documentation (doc/yambar-modules-battery.5.scd) and CHANGELOG.md.

I just finished editing the example config file. :D I will edit the documentation (doc/yambar-modules-battery.5.scd) and CHANGELOG.md.
mz requested review from dnkl 2021年06月14日 19:24:26 +02:00
Owner
Copy link

Just an FYI: you requested a review, but there aren't any more commits (and no force push).

Just so you don't sit around waiting for a review while I'm just sitting here waiting for a push... ;)

Just an FYI: you requested a review, but there aren't any more commits (and no force push). Just so you don't sit around waiting for a review while I'm just sitting here waiting for a push... ;)
Author
Contributor
Copy link

It was to long for a commit message so i edit that :)

It was to long for a commit message so i edit that :)
Author
Contributor
Copy link

Just an FYI: you requested a review, but there aren't any more commits (and no force push).

Just so you don't sit around waiting for a review while I'm just sitting here waiting for a push... ;)

Oh i must accidentally hit the review button. Sorry, my mistake.

> Just an FYI: you requested a review, but there aren't any more commits (and no force push). > > Just so you don't sit around waiting for a review while I'm just sitting here waiting for a push... ;) Oh i must accidentally hit the review button. Sorry, my mistake.
dnkl manually merged commit 8fc0d148c8 into master 2021年06月15日 05:20:07 +02:00
Owner
Copy link

Awesome, thanks!

Awesome, thanks!
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/yambar!58
Reference in a new issue
dnkl/yambar
No description provided.
Delete branch "mz/yambar:master"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?