13
295
Fork
You've already forked yambar
74

module/niri-workspaces: fix crash when monitor off #453

Open
wvdk wants to merge 1 commit from wvdk/yambar:fix-crash-in-niri-workspaces-module into master
pull from: wvdk/yambar:fix-crash-in-niri-workspaces-module
merge into: dnkl:master
dnkl:master
dnkl:releases/1.11
dnkl:releases/1.10
dnkl:releases/1.9
dnkl:releases/1.8
dnkl:releases/1.7
dnkl:releases/1.6
dnkl:releases/1.5
dnkl:releases/1.4
dnkl:releases/1.3
dnkl:releases/1.2
dnkl:releases/1.1
dnkl:releases/1.0
Contributor
Copy link

The niri-workspaces module would crash if niri's event stream produced
a WorkspaceChanged event containing a workspace with no output,
which can occur if the monitor is turned off. Update the response
parser to handle this situation.

The niri-workspaces module would crash if niri's event stream produced a `WorkspaceChanged` event containing a workspace with no output, which can occur if the monitor is turned off. Update the response parser to handle this situation.
module/niri-workspaces: fix crash when monitor off
Some checks reported errors
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job failed
4eb054792e
 
The niri-workspaces module would crash if niri's event stream produced
a `WorkspaceChanged` event containing a workspace with no output,
which can occur if the monitor is turned off. Update the response
parser to handle this situation.
Contributor
Copy link

Looks reasonable to me. I'll look at pulling this into maybar.

Looks reasonable to me. I'll look at pulling this into [`maybar`](https://codeberg.org/mathstuf/maybar).
Contributor
Copy link

Pulled into maybar via mathstuf/maybar#13

Pulled into `maybar` via https://codeberg.org/mathstuf/maybar/pulls/13
Some checks reported errors
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job failed
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix-crash-in-niri-workspaces-module:wvdk-fix-crash-in-niri-workspaces-module
git switch wvdk-fix-crash-in-niri-workspaces-module

Merge

Merge the changes and update on Forgejo.
git switch master
git merge --no-ff wvdk-fix-crash-in-niri-workspaces-module
git switch wvdk-fix-crash-in-niri-workspaces-module
git rebase master
git switch master
git merge --ff-only wvdk-fix-crash-in-niri-workspaces-module
git switch wvdk-fix-crash-in-niri-workspaces-module
git rebase master
git switch master
git merge --no-ff wvdk-fix-crash-in-niri-workspaces-module
git switch master
git merge --squash wvdk-fix-crash-in-niri-workspaces-module
git switch master
git merge --ff-only wvdk-fix-crash-in-niri-workspaces-module
git switch master
git merge wvdk-fix-crash-in-niri-workspaces-module
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/yambar!453
Reference in a new issue
dnkl/yambar
No description provided.
Delete branch "wvdk/yambar:fix-crash-in-niri-workspaces-module"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?