13
295
Fork
You've already forked yambar
74

Implement wp_cursor_shape_v1 #452

Open
spacepineapple24 wants to merge 1 commit from spacepineapple24/yambar:spacepineapple24-patch-1 into master
pull from: spacepineapple24/yambar:spacepineapple24-patch-1
merge into: dnkl:master
dnkl:master
dnkl:releases/1.11
dnkl:releases/1.10
dnkl:releases/1.9
dnkl:releases/1.8
dnkl:releases/1.7
dnkl:releases/1.6
dnkl:releases/1.5
dnkl:releases/1.4
dnkl:releases/1.3
dnkl:releases/1.2
dnkl:releases/1.1
dnkl:releases/1.0
First-time contributor
Copy link

Implements wp_cursor_shape_v1
Based off dnkl/fuzzel@e6c4d5bece

Seems to be working fine from my testing

Implements wp_cursor_shape_v1 Based off https://codeberg.org/dnkl/fuzzel/commit/e6c4d5bece6e85b265a969cd73df579038329109 Seems to be working fine from my testing
Implement wp_cursor_shape_v1
Some checks reported errors
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job failed
56b374b569
Contributor
Copy link

I'm looking at this for maybar. What does this do? I don't see any user-facing controls. Does this fix the scaling issue where the cursor inflates over yambar when using a scaling factor (hi-dpi)?

I'm looking at this for [`maybar`](https://codeberg.org/mathstuf/maybar). What does this *do*? I don't see any user-facing controls. Does this fix the scaling issue where the cursor inflates over `yambar` when using a scaling factor (hi-dpi)?
Author
First-time contributor
Copy link

What does this do? I don't see any user-facing controls.

It implements cursor-shape-v1, which makes the compositor responsible for drawing the cursors. It is important if you want to use svg cursors for example (supported on KDE or Hyprland).

Does this fix the scaling issue where the cursor inflates over yambar when using a scaling factor (hi-dpi)?

Never had that problem, but according to KDE dev blog it seems like it might, if the compositor supports the protocol.

> What does this _do_? I don't see any user-facing controls. It implements [cursor-shape-v1](https://wayland.app/protocols/cursor-shape-v1), which makes the compositor responsible for drawing the cursors. It is important if you want to use svg cursors for example (supported on KDE or Hyprland). > Does this fix the scaling issue where the cursor inflates over `yambar` when using a scaling factor (hi-dpi)? Never had that problem, but according to [KDE dev blog](https://blogs.kde.org/2024/10/09/cursor-size-problems-in-wayland-explained/) it seems like it might, if the compositor supports the protocol.
Contributor
Copy link

Thanks for the info. Mind if I pull it into maybar? Want to submit it yourself?

Thanks for the info. Mind if I pull it into `maybar`? Want to submit it yourself?
Author
First-time contributor
Copy link

@mathstuf wrote in #452 (comment):

Thanks for the info. Mind if I pull it into maybar? Want to submit it yourself?

feel free to
like I said I mostly took the code from a fuzzel commit

@mathstuf wrote in https://codeberg.org/dnkl/yambar/pulls/452#issuecomment-15522686: > Thanks for the info. Mind if I pull it into `maybar`? Want to submit it yourself? feel free to like I said I mostly took the code from a fuzzel commit
Contributor
Copy link

Thanks. Opened as mathstuf/maybar#15 after rebasing.

Thanks. Opened as https://codeberg.org/mathstuf/maybar/pulls/15 after rebasing.
Some checks reported errors
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/alpine-x64 Job failed
This pull request can be merged automatically.
This branch is out-of-date with the base branch
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u spacepineapple24-patch-1:spacepineapple24-spacepineapple24-patch-1
git switch spacepineapple24-spacepineapple24-patch-1

Merge

Merge the changes and update on Forgejo.
git switch master
git merge --no-ff spacepineapple24-spacepineapple24-patch-1
git switch spacepineapple24-spacepineapple24-patch-1
git rebase master
git switch master
git merge --ff-only spacepineapple24-spacepineapple24-patch-1
git switch spacepineapple24-spacepineapple24-patch-1
git rebase master
git switch master
git merge --no-ff spacepineapple24-spacepineapple24-patch-1
git switch master
git merge --squash spacepineapple24-spacepineapple24-patch-1
git switch master
git merge --ff-only spacepineapple24-spacepineapple24-patch-1
git switch master
git merge spacepineapple24-spacepineapple24-patch-1
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/yambar!452
Reference in a new issue
dnkl/yambar
No description provided.
Delete branch "spacepineapple24/yambar:spacepineapple24-patch-1"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?