13
295
Fork
You've already forked yambar
74

WIP: Support docking bar to left and right of the screen #270

Draft
CircleShift wants to merge 17 commits from CircleShift/yambar:sidebar-support into master
pull from: CircleShift/yambar:sidebar-support
merge into: dnkl:master
dnkl:master
dnkl:releases/1.11
dnkl:releases/1.10
dnkl:releases/1.9
dnkl:releases/1.8
dnkl:releases/1.7
dnkl:releases/1.6
dnkl:releases/1.5
dnkl:releases/1.4
dnkl:releases/1.3
dnkl:releases/1.2
dnkl:releases/1.1
dnkl:releases/1.0
First-time contributor
Copy link
  • Support left and right as options for bar location
  • Make height optional
  • Add optional width setting
  • Pre-expose modules so height and width can be auto-configured if omitted
  • Add height member to exposable structs

I am a bit new to open source so critique/feedback on my code is appreciated.

Thanks,
Circle Shift

+ Support `left` and `right` as options for bar location + Make `height` optional + Add optional `width` setting + Pre-expose modules so height and width can be auto-configured if omitted + Add height member to exposable structs I am a bit new to open source so critique/feedback on my code is appreciated. Thanks, Circle Shift
~ Attempt to pre expose modules to calculate proper width/height
~ Doesn't really work, but also doesn't segfault, so a win in my book
+ height is optional
+ width is optional
+ make location enum into bitmask
- Add height attribute to most particles for height generation on the fly
Fix clipping
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
a81db4b2ae
Author
First-time contributor
Copy link

This merge should resolve #65 as well as #40

However, the merge does not have support for pinning the bar to a screen corner

This merge should resolve #65 as well as #40 However, the merge does not have support for pinning the bar to a screen corner
Author
First-time contributor
Copy link

Please note that bar placement using the xcb backend is naive and not fully tested. I am using wayland, but it would be good if someone could test these changes on X.Org

Please note that bar placement using the xcb backend is naive and not fully tested. I am using wayland, but it would be good if someone could test these changes on X.Org
Formally add vertical lists
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
0ab621c82b
 
+ Add vertical as a bool to config verification
+ Fix minor bug with displaying vertical lists
Spelling
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
ddb0c4fcc4
CircleShift changed title from (削除) Bar sizing and placement support (削除ここまで) to Support docking bar to left and right of the screen 2023年02月02日 05:03:59 +01:00
dnkl 2023年03月08日 09:35:11 +01:00
CircleShift changed title from (削除) Support docking bar to left and right of the screen (削除ここまで) to WIP: Support docking bar to left and right of the screen 2023年10月05日 18:31:23 +02:00
Contributor
Copy link

I've not dug into the code deeply, but the feature seems useful enough. Feel free to submit to maybar if you're interested in getting it merged. Good news for you is that I've already ripped out X support there :) .

I've not dug into the code deeply, but the feature seems useful enough. Feel free to submit to [`maybar`](https://codeberg.org/mathstuf/maybar) if you're interested in getting it merged. Good news for you is that I've already ripped out X support there :) .
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
This pull request has changes conflicting with the target branch.
  • bar/bar.c
  • bar/bar.h
  • bar/private.h
  • bar/wayland.c
  • bar/xcb.c
  • config.c
  • modules/i3.c
  • modules/pipewire.c
  • modules/removables.c
  • modules/sway-xkb.c
View command line instructions

Manual merge helper

Use this merge commit message when completing the merge manually.

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u sidebar-support:CircleShift-sidebar-support
git switch CircleShift-sidebar-support

Merge

Merge the changes and update on Forgejo.
git switch master
git merge --no-ff CircleShift-sidebar-support
git switch CircleShift-sidebar-support
git rebase master
git switch master
git merge --ff-only CircleShift-sidebar-support
git switch CircleShift-sidebar-support
git rebase master
git switch master
git merge --no-ff CircleShift-sidebar-support
git switch master
git merge --squash CircleShift-sidebar-support
git switch master
git merge --ff-only CircleShift-sidebar-support
git switch master
git merge CircleShift-sidebar-support
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/yambar!270
Reference in a new issue
dnkl/yambar
No description provided.
Delete branch "CircleShift/yambar:sidebar-support"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?