New modules pipewire #224

Ogromny commented 2022年09月03日 17:33:01 +02:00

This is the continuity of #215

This is the continuity of https://codeberg.org/dnkl/yambar/pulls/215

wvdk commented 2022年09月07日 18:07:17 +02:00

(Responding to @Ogromny in #223 (comment))

@Ogromny, I tried the icon tag, but it is empty for me (both with and without headphones plugged in). Both form_factor and bus are empty as well, unfortunately. Is this something that has to be configured manually in PipeWire?

Hum, can you do a

pw-metadata it should list a source and a sink.

I get this:

$ pw-metadata
Found "default" metadata 36
update: id:0 key:'default.audio.source' value:'{"name":"alsa_input.pci-0000_00_1b.0.analog-stereo"}' type:'Spa:String:JSON'
update: id:0 key:'default.audio.sink' value:'{"name":"alsa_output.pci-0000_00_1b.0.analog-stereo"}' type:'Spa:String:JSON'

Now do a pw-cli ls Node, you should see your Sink Node and your Source Node.

Now take note of a Node id, let say that your Sink Node id is 35, do a pw-dump 35 and under the props object (at the top of the output) you see a device.icon-name, that's the icon tag, device.bus is the bus tag and device.form-factor is the form-factor tag.

The device.icon-name and device.bus should be always present and non empty. So maybe it's a misconfigured pipewire (missing wireplumber or pipewire-media-session), missing configuration for pipewire-pulse or simply a bug.

pw-cli ls Node shows me that the sink node has ID 47, and pw-dump 47 gives the following output (I can post the full output if you want):

...
"props": {
 "alsa.card": 1,
 "alsa.card_name": "HDA Intel PCH",
 "alsa.class": "generic",
 "alsa.device": 0,
 "alsa.driver_name": "snd_hda_intel",
 "alsa.id": "ALC283 Analog",
 "alsa.long_card_name": "HDA Intel PCH at 0x7eb1c000 irq 46",
 "alsa.name": "ALC283 Analog",
 "alsa.resolution_bits": 16,
 "alsa.subclass": "generic-mix",
 "alsa.subdevice": 0,
 "alsa.subdevice_name": "subdevice #0",
 "api.alsa.card.longname": "HDA Intel PCH at 0x7eb1c000 irq 46",
 "api.alsa.card.name": "HDA Intel PCH",
 "api.alsa.path": "front:1",
 "api.alsa.pcm.card": 1,
 "api.alsa.pcm.stream": "playback",
 "audio.channels": 2,
 "audio.position": "FL,FR",
 "card.profile.device": 3,
 "device.api": "alsa",
 "device.class": "sound",
 "device.id": 41,
 "device.profile.description": "Analog Stereo",
 "device.profile.name": "analog-stereo",
 "device.routes": 2,
 "factory.name": "api.alsa.pcm.sink",
 "media.class": "Audio/Sink",
 "node.description": "Built-in Audio Analog Stereo",
 "node.name": "alsa_output.pci-0000_00_1b.0.analog-stereo",
 "node.nick": "ALC283 Analog",
 "node.pause-on-idle": false,
 "object.path": "alsa:pcm:1:front:1:playback",
 "priority.driver": 1009,
 "priority.session": 1009,
 "factory.id": 18,
 "clock.quantum-limit": 8192,
 "client.id": 35,
 "node.driver": true,
 "factory.mode": "merge",
 "audio.adapt.follower": "",
 "library.name": "audioconvert/libspa-audioconvert",
 "object.id": 47,
 "object.serial": 48
},
...

As you can see, device.icon-name, device.bus and device.form-factor are all missing. I tried removing ~/.local/state/{pipewire,wireplumber} (with pipewire and wireplumber stopped), but the issue remains.

Any ideas how I can investigate further what's going on here?

(Responding to @Ogromny in https://codeberg.org/dnkl/yambar/pulls/223#issuecomment-615123) > > @Ogromny, I tried the `icon` tag, but it is empty for me (both with and without headphones plugged in). Both `form_factor` and `bus` are empty as well, unfortunately. Is this something that has to be configured manually in PipeWire? > > Hum, can you do a > > `pw-metadata` it should list a source and a sink. I get this: ```console $ pw-metadata Found "default" metadata 36 update: id:0 key:'default.audio.source' value:'{"name":"alsa_input.pci-0000_00_1b.0.analog-stereo"}' type:'Spa:String:JSON' update: id:0 key:'default.audio.sink' value:'{"name":"alsa_output.pci-0000_00_1b.0.analog-stereo"}' type:'Spa:String:JSON' ``` > Now do a `pw-cli ls Node`, you should see your Sink Node and your Source Node. > > Now take note of a Node id, let say that your Sink Node id is 35, do a `pw-dump 35` and under the `props` object (at the top of the output) you see a `device.icon-name`, that's the `icon` tag, `device.bus` is the `bus` tag and `device.form-factor` is the `form-factor` tag. > > The `device.icon-name` and `device.bus` should be always present and non empty. So maybe it's a misconfigured pipewire (missing wireplumber or pipewire-media-session), missing configuration for pipewire-pulse or simply a bug. `pw-cli ls Node` shows me that the sink node has ID 47, and `pw-dump 47` gives the following output (I can post the full output if you want): ``` ... "props": { "alsa.card": 1, "alsa.card_name": "HDA Intel PCH", "alsa.class": "generic", "alsa.device": 0, "alsa.driver_name": "snd_hda_intel", "alsa.id": "ALC283 Analog", "alsa.long_card_name": "HDA Intel PCH at 0x7eb1c000 irq 46", "alsa.name": "ALC283 Analog", "alsa.resolution_bits": 16, "alsa.subclass": "generic-mix", "alsa.subdevice": 0, "alsa.subdevice_name": "subdevice #0", "api.alsa.card.longname": "HDA Intel PCH at 0x7eb1c000 irq 46", "api.alsa.card.name": "HDA Intel PCH", "api.alsa.path": "front:1", "api.alsa.pcm.card": 1, "api.alsa.pcm.stream": "playback", "audio.channels": 2, "audio.position": "FL,FR", "card.profile.device": 3, "device.api": "alsa", "device.class": "sound", "device.id": 41, "device.profile.description": "Analog Stereo", "device.profile.name": "analog-stereo", "device.routes": 2, "factory.name": "api.alsa.pcm.sink", "media.class": "Audio/Sink", "node.description": "Built-in Audio Analog Stereo", "node.name": "alsa_output.pci-0000_00_1b.0.analog-stereo", "node.nick": "ALC283 Analog", "node.pause-on-idle": false, "object.path": "alsa:pcm:1:front:1:playback", "priority.driver": 1009, "priority.session": 1009, "factory.id": 18, "clock.quantum-limit": 8192, "client.id": 35, "node.driver": true, "factory.mode": "merge", "audio.adapt.follower": "", "library.name": "audioconvert/libspa-audioconvert", "object.id": 47, "object.serial": 48 }, ... ``` As you can see, `device.icon-name`, `device.bus` and `device.form-factor` are all missing. I tried removing `~/.local/state/{pipewire,wireplumber}` (with `pipewire` and `wireplumber` stopped), but the issue remains. Any ideas how I can investigate further what's going on here?

Ogromny commented 2022年09月07日 22:13:55 +02:00

(Responding to @Ogromny in #223 (comment))

@Ogromny, I tried the icon tag, but it is empty for me (both with and without headphones plugged in). Both form_factor and bus are empty as well, unfortunately. Is this something that has to be configured manually in PipeWire?

Hum, can you do a

pw-metadata it should list a source and a sink.

I get this:

$ pw-metadata
Found "default" metadata 36
update: id:0 key:'default.audio.source' value:'{"name":"alsa_input.pci-0000_00_1b.0.analog-stereo"}' type:'Spa:String:JSON'
update: id:0 key:'default.audio.sink' value:'{"name":"alsa_output.pci-0000_00_1b.0.analog-stereo"}' type:'Spa:String:JSON'

Now do a pw-cli ls Node, you should see your Sink Node and your Source Node.

Now take note of a Node id, let say that your Sink Node id is 35, do a pw-dump 35 and under the props object (at the top of the output) you see a device.icon-name, that's the icon tag, device.bus is the bus tag and device.form-factor is the form-factor tag.

The device.icon-name and device.bus should be always present and non empty. So maybe it's a misconfigured pipewire (missing wireplumber or pipewire-media-session), missing configuration for pipewire-pulse or simply a bug.

pw-cli ls Node shows me that the sink node has ID 47, and pw-dump 47 gives the following output (I can post the full output if you want):

...
"props": {
 "alsa.card": 1,
 "alsa.card_name": "HDA Intel PCH",
 "alsa.class": "generic",
 "alsa.device": 0,
 "alsa.driver_name": "snd_hda_intel",
 "alsa.id": "ALC283 Analog",
 "alsa.long_card_name": "HDA Intel PCH at 0x7eb1c000 irq 46",
 "alsa.name": "ALC283 Analog",
 "alsa.resolution_bits": 16,
 "alsa.subclass": "generic-mix",
 "alsa.subdevice": 0,
 "alsa.subdevice_name": "subdevice #0",
 "api.alsa.card.longname": "HDA Intel PCH at 0x7eb1c000 irq 46",
 "api.alsa.card.name": "HDA Intel PCH",
 "api.alsa.path": "front:1",
 "api.alsa.pcm.card": 1,
 "api.alsa.pcm.stream": "playback",
 "audio.channels": 2,
 "audio.position": "FL,FR",
 "card.profile.device": 3,
 "device.api": "alsa",
 "device.class": "sound",
 "device.id": 41,
 "device.profile.description": "Analog Stereo",
 "device.profile.name": "analog-stereo",
 "device.routes": 2,
 "factory.name": "api.alsa.pcm.sink",
 "media.class": "Audio/Sink",
 "node.description": "Built-in Audio Analog Stereo",
 "node.name": "alsa_output.pci-0000_00_1b.0.analog-stereo",
 "node.nick": "ALC283 Analog",
 "node.pause-on-idle": false,
 "object.path": "alsa:pcm:1:front:1:playback",
 "priority.driver": 1009,
 "priority.session": 1009,
 "factory.id": 18,
 "clock.quantum-limit": 8192,
 "client.id": 35,
 "node.driver": true,
 "factory.mode": "merge",
 "audio.adapt.follower": "",
 "library.name": "audioconvert/libspa-audioconvert",
 "object.id": 47,
 "object.serial": 48
},
...

As you can see, device.icon-name, device.bus and device.form-factor are all missing. I tried removing ~/.local/state/{pipewire,wireplumber} (with pipewire and wireplumber stopped), but the issue remains.

Any ideas how I can investigate further what's going on here?

Thanks for the informations, that's weird... I tried to find similar issues on the pipewire gitlab but no one seems to have thing like that. Hum what's your pipewire/wireplumber version ? And I don't know if pulseaudio provide same informations like icon or form-factor. From memory you can do a pactl info or something similar and it'll show you the corresponding icon for the currently selected profile. Or maybe it's pactl list cards, IIRC it'll show a Selected Profile or thing like that with a icon-name field

> (Responding to @Ogromny in https://codeberg.org/dnkl/yambar/pulls/223#issuecomment-615123) > > > > @Ogromny, I tried the `icon` tag, but it is empty for me (both with and without headphones plugged in). Both `form_factor` and `bus` are empty as well, unfortunately. Is this something that has to be configured manually in PipeWire? > > > > Hum, can you do a > > > > `pw-metadata` it should list a source and a sink. > > I get this: > ```console > $ pw-metadata > Found "default" metadata 36 > update: id:0 key:'default.audio.source' value:'{"name":"alsa_input.pci-0000_00_1b.0.analog-stereo"}' type:'Spa:String:JSON' > update: id:0 key:'default.audio.sink' value:'{"name":"alsa_output.pci-0000_00_1b.0.analog-stereo"}' type:'Spa:String:JSON' > ``` > > > Now do a `pw-cli ls Node`, you should see your Sink Node and your Source Node. > > > > Now take note of a Node id, let say that your Sink Node id is 35, do a `pw-dump 35` and under the `props` object (at the top of the output) you see a `device.icon-name`, that's the `icon` tag, `device.bus` is the `bus` tag and `device.form-factor` is the `form-factor` tag. > > > > The `device.icon-name` and `device.bus` should be always present and non empty. So maybe it's a misconfigured pipewire (missing wireplumber or pipewire-media-session), missing configuration for pipewire-pulse or simply a bug. > > `pw-cli ls Node` shows me that the sink node has ID 47, and `pw-dump 47` gives the following output (I can post the full output if you want): > > ``` > ... > "props": { > "alsa.card": 1, > "alsa.card_name": "HDA Intel PCH", > "alsa.class": "generic", > "alsa.device": 0, > "alsa.driver_name": "snd_hda_intel", > "alsa.id": "ALC283 Analog", > "alsa.long_card_name": "HDA Intel PCH at 0x7eb1c000 irq 46", > "alsa.name": "ALC283 Analog", > "alsa.resolution_bits": 16, > "alsa.subclass": "generic-mix", > "alsa.subdevice": 0, > "alsa.subdevice_name": "subdevice #0", > "api.alsa.card.longname": "HDA Intel PCH at 0x7eb1c000 irq 46", > "api.alsa.card.name": "HDA Intel PCH", > "api.alsa.path": "front:1", > "api.alsa.pcm.card": 1, > "api.alsa.pcm.stream": "playback", > "audio.channels": 2, > "audio.position": "FL,FR", > "card.profile.device": 3, > "device.api": "alsa", > "device.class": "sound", > "device.id": 41, > "device.profile.description": "Analog Stereo", > "device.profile.name": "analog-stereo", > "device.routes": 2, > "factory.name": "api.alsa.pcm.sink", > "media.class": "Audio/Sink", > "node.description": "Built-in Audio Analog Stereo", > "node.name": "alsa_output.pci-0000_00_1b.0.analog-stereo", > "node.nick": "ALC283 Analog", > "node.pause-on-idle": false, > "object.path": "alsa:pcm:1:front:1:playback", > "priority.driver": 1009, > "priority.session": 1009, > "factory.id": 18, > "clock.quantum-limit": 8192, > "client.id": 35, > "node.driver": true, > "factory.mode": "merge", > "audio.adapt.follower": "", > "library.name": "audioconvert/libspa-audioconvert", > "object.id": 47, > "object.serial": 48 > }, > ... > ``` > > As you can see, `device.icon-name`, `device.bus` and `device.form-factor` are all missing. I tried removing `~/.local/state/{pipewire,wireplumber}` (with `pipewire` and `wireplumber` stopped), but the issue remains. > > Any ideas how I can investigate further what's going on here? Thanks for the informations, that's weird... I tried to find similar issues on the pipewire gitlab but no one seems to have thing like that. Hum what's your pipewire/wireplumber version ? And I don't know if pulseaudio provide same informations like `icon` or `form-factor`. From memory you can do a `pactl info` or something similar and it'll show you the corresponding icon for the currently selected profile. Or maybe it's `pactl list cards`, IIRC it'll show a `Selected Profile` or thing like that with a `icon-name` field

wvdk commented 2022年09月08日 19:58:27 +02:00

Yeah, I couldn't find any relevant pipewire/wireplumber issues either.

I'm using pipewire 0.3.57 and wireplumber 0.4.11.

pactl list cards shows the properties device.bus, device.form_factor and device.icon_name for the card, and just device.icon_name for each port; pactl list sinks shows all three properties for the sink.

I have another laptop lying around here that also uses Intel HD Audio; I'll see if it is any different there.

Yeah, I couldn't find any relevant pipewire/wireplumber issues either. I'm using pipewire 0.3.57 and wireplumber 0.4.11. `pactl list cards` shows the properties `device.bus`, `device.form_factor` and `device.icon_name` for the card, and just `device.icon_name` for each port; `pactl list sinks` shows all three properties for the sink. I have another laptop lying around here that also uses Intel HD Audio; I'll see if it is any different there.

wvdk commented 2022年09月08日 21:11:50 +02:00

Update: I tried the other laptop, and got the same results.

By the way, I noticed that devices (PipeWire:Interface:Device) do have the properties device.bus, device.form-factor and device.icon-name on my machine.

Update: I tried the other laptop, and got the same results. By the way, I noticed that devices (`PipeWire:Interface:Device`) _do_ have the properties `device.bus`, `device.form-factor` and `device.icon-name` on my machine.

Ogromny commented 2022年09月08日 21:51:26 +02:00

Hum, okay I think I know how to find/provide theses informations. I will try to do that by tomorrow

Edit: I found how to get icon, form-factor, etc, exactly like pactl does, I'm quite busy right now, I think it will be finished in 2-3 days, just to let you know.

Hum, okay I think I know how to find/provide theses informations. I will try to do that by tomorrow Edit: I found how to get icon, form-factor, etc, exactly like pactl does, I'm quite busy right now, I think it will be finished in 2-3 days, just to let you know.

Ogromny commented 2022年09月12日 15:28:38 +02:00

@wvdk Can you retry please, it should be good

@wvdk Can you retry please, it should be good

wvdk commented 2022年09月12日 20:38:18 +02:00

@Ogromny, it seems to work now, nice! For the sink, icon gives me audio-headphones/audio-speakers, form_factor gives me headphones/speaker, and bus is empty. For the source, icon gives me audio-input-microphone and form_factor gives me mic (and bus is empty).

I do have one other issue though: the module causes yambar to hang sometimes (when pressing Ctrl-C). I noticed you don't listen on abort_fd; maybe that's what causes this behavior?

@Ogromny, it seems to work now, nice! For the sink, `icon` gives me `audio-headphones`/`audio-speakers`, `form_factor` gives me `headphones`/`speaker`, and `bus` is empty. For the source, `icon` gives me `audio-input-microphone` and `form_factor` gives me `mic` (and `bus` is empty). I do have one other issue though: the module causes `yambar` to hang sometimes (when pressing Ctrl-C). I noticed you don't listen on `abort_fd`; maybe that's what causes this behavior?

Ogromny commented 2022年09月12日 21:16:27 +02:00

@wvdk yeah bus for me is almost always empty except for the bluetooth source/sink, do you think we should keep it or we should remove it ?

Concerning the hang issue, I experiences it too, let me some days and it will be fixed too !

Glad to hear that the module now work almost properly for you now.

@wvdk yeah `bus` for me is almost always empty except for the bluetooth source/sink, do you think we should keep it or we should remove it ? Concerning the hang issue, I experiences it too, let me some days and it will be fixed too ! Glad to hear that the module now work almost properly for you now.

Ogromny commented 2022年09月16日 13:48:46 +02:00

@wvdk Sorry for the delay, should be good, the module listens to abort_fd now

@wvdk Sorry for the delay, should be good, the module listens to `abort_fd` now

wvdk commented 2022年09月21日 19:32:15 +02:00

@Ogromny, that seems to have fixed the hangs indeed!

@Ogromny, that seems to have fixed the hangs indeed!

dnkl commented 2022年12月09日 15:27:01 +01:00

Are there any outstanding issues remaining?

Are there any outstanding issues remaining?

Ogromny commented 2022年12月12日 09:28:01 +01:00

My bad I forgot, added now

My bad I forgot, added now

Ogromny commented 2022年12月13日 10:30:49 +01:00

Should be good !

Should be good !

dnkl commented 2022年12月13日 10:39:24 +01:00

Awesome job, thanks!

Awesome job, thanks!