Add keyboard-focus=exclusive|on-demand command line and config option #492

bbb651 commented 2025年03月04日 13:31:40 +01:00

Some asked in the niri matrix room if this was possible and it seemed quite straight forward and useful. Not entirely sure about the name and documentation, I tried to avoid bikeshedding.

Some [asked](https://matrix.to/#/!KIjqiaZyJFkPXxMmGQ:gnome.org/$IuB1rQ0TWPIQ_28OFqScpklRv0vpgvTE-nDlk0mFJak?via=gnome.org&via=matrix.org&via=tchncs.de) in the niri matrix room if this was possible and it seemed quite straight forward and useful. Not entirely sure about the name and documentation, I tried to avoid bikeshedding.

bbb651 commented 2025年03月05日 19:16:11 +01:00

I find the documentation (of fuzzel's options) hard to understand. That needs to be improved.

I'll try, I'm not used to writing man pages. In general I don't like the duplication between fuzzel(1), fuzzel.ini(5) and --help, I know they serve different purposes but especially with flags that just set config options like this one it feels a bit redundant

It might also make more sense to add an enum-like command line/config option, rather than a boolean: keyboard-focus=exclusive|on-demand perhaps? Defaulting to exclusive.

I agree, even if it's unlikely there'll be additional variants it's just as short and more intuitive to override. Probably also focus over interactivity, I wanted to match the protocol but it could just be mentioned in the man page.

Edit: Unrelated to this PR, I noticed layer defaults to overlay but --help says it defaults to top. This is what I'm talking about, when there's no single source of truth, documentation, completions, etc. eventually go out of date

> I find the documentation (of fuzzel's options) hard to understand. That needs to be improved. I'll try, I'm not used to writing man pages. In general I don't like the duplication between `fuzzel(1)`, `fuzzel.ini(5)` and `--help`, I know they serve different purposes but especially with flags that just set config options like this one it feels a bit redundant > It might also make more sense to add an enum-like command line/config option, rather than a boolean: `keyboard-focus=exclusive|on-demand` perhaps? Defaulting to `exclusive`. I agree, even if it's unlikely there'll be additional variants it's just as short and more intuitive to override. Probably also `focus` over `interactivity`, I wanted to match the protocol but it could just be mentioned in the man page. Edit: Unrelated to this PR, I noticed `layer` defaults to `overlay` but `--help` says it defaults to top. This is what I'm talking about, when there's no single source of truth, documentation, completions, etc. eventually go out of date

bbb651 commented 2025年03月07日 11:08:48 +01:00

I accidentally force pushed the branch to master while trying to resolve the submodule being removed (some weird interaction with jj and force pushing), and that made codeberg think it's been manually merged... is it possible to reopen the PR? The commit should be good now: bbb651/fuzzel@466abbe0f7

I accidentally force pushed the branch to master while trying to resolve the submodule being removed (some weird interaction with jj and force pushing), and that made codeberg think it's been manually merged... is it possible to reopen the PR? The commit should be good now: https://codeberg.org/bbb651/fuzzel/commit/466abbe0f756f2e88c45be18284f3afc8900bb3b