20
849
Fork
You've already forked fuzzel
83

deps: bump required fcft version #162

Closed
markstos wants to merge 1 commit from markstos/fuzzel:bump-fcft-to-3.1.3 into master
pull from: markstos/fuzzel:bump-fcft-to-3.1.3
merge into: dnkl:master
dnkl:master
dnkl:gnome-support
dnkl:releases/1.14
dnkl:issue-319-window-switching
dnkl:issue-561-nord-theme-only
dnkl:resvg-filtering-take-2
dnkl:resvg-filtering
dnkl:releases/1.13
dnkl:rehanzo-dont-ignore-execute-648
dnkl:keybinds-overwrite
dnkl:issue-561-refresh-theme
dnkl:ci-automated-testing
dnkl:reenable-legacy-icons
dnkl:releases/1.12
dnkl:test-coverage-for-fzf-caching
dnkl:releases/1.11
dnkl:releases/1.10
dnkl:releases/1.9
dnkl:releases/1.8
dnkl:releases/1.7
dnkl:releases/1.6
dnkl:releases/1.5
dnkl:releases/1.4
dnkl:releases/1.3
dnkl:releases/1.2
dnkl:releases/1.1
dnkl:releases/1.0
Collaborator
Copy link

Addresses font shaping bug affecting fuzzel:
#155

Addresses font shaping bug affecting fuzzel: https://codeberg.org/dnkl/fuzzel/pulls/155
markstos force-pushed bump-fcft-to-3.1.3 from 7053c70576
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
to a4923d1d14
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2022年09月21日 16:13:18 +02:00 Compare
Owner
Copy link

Shouldn't we bump it to 3.1.5 instead? Seeing that 3.1.4 is broken on HarfBuzz >= 5.2.

Shouldn't we bump it to 3.1.5 instead? Seeing that 3.1.4 is broken on HarfBuzz >= 5.2.
Author
Collaborator
Copy link

I think we should bump it to 3.1.5 once 3.1.5 is packaged for Arch. I guess it could be doneknow, but it would break for anyone who is using the fuzzel PKGBUILD to build fuzzel from Git but has not also built fcft 3.1.5 on their own.

So it seems better to bump to 3.1.4 now since it's been packaged, and bump to 3.1.5 once that's been packaged.

I think we should bump it to 3.1.5 once 3.1.5 is packaged for Arch. I guess it could be doneknow, but it would break for anyone who is using the fuzzel PKGBUILD to build fuzzel from Git but has not also built `fcft` 3.1.5 on their own. So it seems better to bump to 3.1.4 now since it's been packaged, and bump to 3.1.5 once that's been packaged.
Owner
Copy link

Sorry for not replying sooner. I didn't think it was a good idea to bump to 3.1.4 on Arch, since fcft-3.1.4 + harfbuzz-5.2 was a known broken combo.

Arch community has now updated fcft to 3.1.5, and thus I think we should bump to that. However, I don't think we should just bump the PKGBUILD, but the meson.build too. Either that or simply remove the PKGBUILD from this repo (we don't carry any other packaging scripts...).

Sorry for not replying sooner. I didn't think it was a good idea to bump to 3.1.4 on Arch, since fcft-3.1.4 + harfbuzz-5.2 was a known broken combo. Arch community has now updated fcft to 3.1.5, and thus I think we should bump to that. However, I don't think we should _just_ bump the PKGBUILD, but the `meson.build` too. Either that or simply remove the PKGBUILD from this repo (we don't carry any other packaging scripts...).
markstos force-pushed bump-fcft-to-3.1.3 from a4923d1d14
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
to afe622148c
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful
2022年09月28日 17:31:40 +02:00 Compare
Author
Collaborator
Copy link

I've bumped both files to 3.1.5 now.

Either that or simply remove the PKGBUILD from this repo (we don't carry any other packaging scripts...).

Whether you keep the PKGBUILD or not is up to you, but I suspect that Arch has the majority of fuzzel users, so it might be worth special status.

I've confirmed that all my emoji-related problems are fixed now!

I've bumped both files to 3.1.5 now. > Either that or simply remove the PKGBUILD from this repo (we don't carry any other packaging scripts...). Whether you keep the PKGBUILD or not is up to you, but I suspect that Arch has the majority of fuzzel users, so it might be worth special status. I've confirmed that all my emoji-related problems are fixed now!
Owner
Copy link

I decided not to bump the requirement. There are no crash-related fixes needed, and the whole harfbuzz mess makes me think it's better to keep the current version requirement, and let distro packagers deal with fcft.

I decided not to bump the requirement. There are no crash-related fixes needed, and the whole harfbuzz mess makes me think it's better to keep the current version requirement, and let distro packagers deal with fcft.
dnkl closed this pull request 2022年10月23日 14:40:05 +02:00
All checks were successful
ci/woodpecker/pr/woodpecker Pipeline was successful

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/fuzzel!162
Reference in a new issue
dnkl/fuzzel
No description provided.
Delete branch "markstos/fuzzel:bump-fcft-to-3.1.3"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?