Use logical DPI+scale factor when scaling fonts #6

dnkl commented 2020年03月11日 16:14:41 +01:00

This fixes an issue where the fonts were rendered too small when the
output had fractional scaling.

For integral scaling, using the logical (scaled) DPI multiplied with
the scaling factor results in the same final DPI value as if we had
used the physical DPI.

But for fractional scaling, this works around the fact that the
compositor downscales the surface after we've rendered it.

Closes #5

@nikp123 would you like to take this for a spin before I merge it?

This fixes an issue where the fonts were rendered too small when the output had fractional scaling. For integral scaling, using the logical (scaled) DPI multiplied with the scaling factor results in the same final DPI value as if we had used the physical DPI. But for fractional scaling, this works around the fact that the compositor downscales the surface after we've rendered it. Closes #5 @nikp123 would you like to take this for a spin before I merge it?

nikp123 commented 2020年03月11日 19:23:20 +01:00

@dnkl Sorry for the late response, but it doesn't seem to work. It produces the same result.

@dnkl Sorry for the late response, but it doesn't seem to work. It produces the same result.

dnkl commented 2020年03月11日 20:14:33 +01:00

Is there no difference at all, or is it different, but still not what you expected?

More importantly, can you post the output of, first:

foot --version

and then the full log output from when you start a new foot instance and then move it between the two monitors?

All the above using the build from this PR, of course.

Is there no difference at all, or is it different, but still not what you expected? More importantly, can you post the output of, first: ```sh foot --version ``` and then the **full** log output from when you start a new foot instance and then move it between the two monitors? All the above using the build from this PR, of course.

dnkl commented 2020年03月13日 18:49:53 +01:00

@nikp123 I went ahead and merged this into master. If you, after updating to latest master, are still having font size issues, please open a new issue with log output as described above

@nikp123 I went ahead and merged this into master. If you, after updating to latest master, are still having font size issues, please open a new issue with log output as described above