dnkl/foot
41
2.0k
Fork
You've already forked foot
243

selection: fix word boundary check #2406

Open
cismonx wants to merge 1 commit from cismonx/foot:fix/word-boundary into master
pull from: cismonx/foot:fix/word-boundary
merge into: dnkl:master
dnkl:master
dnkl:osc-5522
dnkl:sixel-heap-buffer-overflow
dnkl:releases/1.27
dnkl:releases/1.26
dnkl:releases/1.25
dnkl:releases/1.24
dnkl:multi-cursor
dnkl:releases/1.23
dnkl:pixman-16f-2
dnkl:releases/1.22
dnkl:releases/1.21
dnkl:releases/1.20
dnkl:releases/1.19
dnkl:releases/1.18
dnkl:releases/1.17
dnkl:releases/1.16
dnkl:releases/1.15
dnkl:releases/1.14
dnkl:releases/1.13
dnkl:releases/1.12
dnkl:releases/1.11
dnkl:releases/1.10
dnkl:releases/1.9
dnkl:releases/1.8
dnkl:releases/1.7
dnkl:releases/1.6
dnkl:releases/1.5
dnkl:releases/1.4
dnkl:releases/1.3
dnkl:releases/1.2
dnkl:releases/1.1
dnkl:releases/1.0
Contributor
Copy link

This patch fixes rightmost boundary check for a word wrapped to another line,
where a multi-column character appears as the last character in the original line.

Quick steps to reproduce:

  1. Run printf '\e[%dC👉👉👈👈\n' "$(($(stty size | cut -d' ' -f2) - 4))" in shell.
  2. Double-click (if bound to select-word) on any of the emoji characters in the first line.

All 4 emoji characters are expected to be selected, however, the characters in
the second line are not selected.

This patch fixes rightmost boundary check for a word wrapped to another line, where a multi-column character appears as the last character in the original line. --- Quick steps to reproduce: 1. Run `printf '\e[%dC👉👉👈👈\n' "$(($(stty size | cut -d' ' -f2) - 4))"` in shell. 2. Double-click (if bound to `select-word`) on any of the emoji characters in the **first** line. All 4 emoji characters are expected to be selected, however, the characters in the second line are _not_ selected.
selection: fix word boundary check
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/freebsd-x64 Job completed
528d84009a
 
This patch fixes rightmost boundary check for a word wrapped to
another line, where a multi-column character appears as the last
character in the original line.
Some checks are pending
ci/woodpecker/pr/woodpecker Pipeline is pending approval
builds.sr.ht/freebsd-x64 Job completed
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u fix/word-boundary:cismonx-fix/word-boundary
git switch cismonx-fix/word-boundary

Merge

Merge the changes and update on Forgejo.
git switch master
git merge --no-ff cismonx-fix/word-boundary
git switch cismonx-fix/word-boundary
git rebase master
git switch master
git merge --ff-only cismonx-fix/word-boundary
git switch cismonx-fix/word-boundary
git rebase master
git switch master
git merge --no-ff cismonx-fix/word-boundary
git switch master
git merge --squash cismonx-fix/word-boundary
git switch master
git merge --ff-only cismonx-fix/word-boundary
git switch master
git merge cismonx-fix/word-boundary
git push origin master
Sign in to join this conversation.
No reviewers
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
dnkl/foot!2406
Reference in a new issue
dnkl/foot
No description provided.
Delete branch "cismonx/foot:fix/word-boundary"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?